Plugin panel does not display properly in Safari

Salandora / OctoPrint-SystemCommandEditor

This plugin makes System Commands editable through the OctoPrint WebUI

GNU Affero General Public License v3.0

9 stars 9 forks source link

Plugin panel does not display properly in Safari #4

Closed cptserial closed 6 years ago

cptserial commented 8 years ago

Hi. Thank you for this plugin, it is really awesome.

I have been having this bug for awhile, so I don't think it started in the most recent Safari update. When I go to Settings and choose System Command Editor, most of the interface is hidden. If I place my cursor perpendicular to the heading and scroll, I can scroll down and see a small slice of the interface at a time. I have attached screenshots to illustrate if this explanation doesn't make sense. Your other plugin, Custom Control Editor, works perfectly.

I am running Mac OS X 10.11.3 with Safari 9.0.3.

system_command_editor_on _open sysem_command_editor_scrolled_down custom_control_editor_on_open

Salandora commented 8 years ago

Alright I'll check that when I have some time, propebly not before the 20th of February, sorry. I would need somehelp with this, because I do not have a Mac or something to run Safari.

cptserial commented 8 years ago

No problem! Thank you for taking a look at it when you have the time. Just let me know anything you need me to do.

On Feb 11, 2016, at 5:03 AM, Salandora notifications@github.com wrote:

Alright I'll check that when I have some time, propebly not before the 20th of February, sorry. I would need somehelp with this, because I do not have a Mac or something to run Safari.

— Reply to this email directly or view it on GitHub https://github.com/Salandora/OctoPrint-SystemCommandEditor/issues/4#issuecomment-182854310.

JohnnyricoMC commented 8 years ago

When using the safari web inspector or another functionally similar tool to remove "scrollable" from <div class="tab-content span9 scrollable" id="settings_dialog_content"> , becoming <div class="tab-content span9" id="settings_dialog_content">, the system command editor becomes fully accessible for me:

before:

after:

result:

Based on this, I think the problem might actually be an Octoprint issue rather than one in the plug-in. Just thought I'd report this finding.

OutsourcedGuru commented 6 years ago

Same here. Since people are talking about it on the OctoPrint forum as well, I've pointed them here and I'm linking that post here.

OutsourcedGuru commented 6 years ago

Fixed in PR and it's been merged, so this should be closed soon enough.

Salandora commented 6 years ago

Alright I pushed a new release and hopefully this will fix this problem.

Will close the issue in hope it can stay closed. If the problem still appears feel free to open a new issue or comment here, I'll reopen it then.

Also here too a special thank you to you @OutsourcedGuru for fixing this bug.