Salandora / SophisticatedCore

https://www.curseforge.com/minecraft/mc-mods/sophisticated-core-unofficial-fabric-port
GNU General Public License v3.0
4 stars 4 forks source link

Server Crash with litematica #2

Closed Shadowbee27 closed 4 months ago

Shadowbee27 commented 5 months ago

Describe the bug When i tried viewing the material list of a farm in litemetica the server closed, because it crashed [crash-2024-05-30_14.31.58-server.txt](https://github.com/Salandora/SophisticatedCore/files/15500128/crash-2024-05-30_14.31.58-server.txt) to reproduce:

  1. start the server
  2. in game press m to open litematica main menu
  3. click load schematic
  4. choose one
  5. click material list
  6. server crash

Expected behavior server crash

Shadowbee27 commented 5 months ago

I´ve been testing and the server even crashes when the mod is only installed on the client

Salandora commented 5 months ago

Ohh I know what is going on, as a quick fix add litematica to the server. I accidentialy used a class from litematica without realizing it would be a problem....

Salandora commented 5 months ago

Correction don't add litematica, the class I used is in malilib, so adding malilib should be sufficient. Sorry for the confusion

Shadowbee27 commented 5 months ago

Hm the server still crashes, probably becaues malilib is only client side

Salandora commented 5 months ago

Wait what? Okay now I need to dig deeper into this, malilib should have solved that problem as the utility class I used is in there. Do you happen to have a new crash log?

Shadowbee27 commented 5 months ago

crash-2024-05-30_14.31.58-server.txt Yes

Salandora commented 5 months ago

That's the old one that you already posted in the report.

Salandora commented 5 months ago

Okay I additionally checked malilib real quick and yeah the fabric.mod.json is specifically set to client environments so the whole workaround would not work.

I should have a proper fix ready in a couple minutes, would you like to test it then?

Shadowbee27 commented 5 months ago

crash-2024-05-30_16.29.23-server.txt This is the newest

Shadowbee27 commented 5 months ago

Screenshot 2024-05-30 180721 Here are all mods form the server mod folder

Shadowbee27 commented 5 months ago

Yes I can test it

Salandora commented 5 months ago

Okay github finished compiling now: https://github.com/Salandora/SophisticatedMods/actions/runs/9305793040

You wanna download the Artifacts file, it's a zip file. In there you'll find a bunch of files you need these:

Shadowbee27 commented 5 months ago

With the new version the porblem is fixed

Salandora commented 4 months ago

Bugfix release is out.