SalesforceCommerceCloud / b2c-crm-sync

... a contemporary perspective on how to integrate B2C Commerce and the Salesforce Customer 360 Platform to power frictionless customer experiences in the B2C domain.
https://salesforcecommercecloud.github.io/b2c-crm-sync/
BSD 3-Clause "New" or "Revised" License
65 stars 45 forks source link

High Vulnerabilities found - #92

Open neeraj-jain01 opened 2 years ago

neeraj-jain01 commented 2 years ago

When running npm install step, it reported 76 vulnerabilities (2 low, 69 moderate, 5 high). Is it normal ? I ran npm audit fix. The number and type of vulnerabilities remained same. I went ahead with the deployment instructions but in step 14 (Deploy the b2c-crm-sync Application Code to Your Salesforce Org) , deployment fails :

npm run crm-sync:sf:org:deploy ....

-- deploying the base meta-data to the specified Salesforce Org; please standby ,----------------------------------------------------------------------.
88888888888 88
88 88
88 88
88aaaaa 8b,dPPYba, 8b,dPPYba, ,adPPYba, 8b,dPPYba, 88
88"“”"” 88P’ “Y8 88P’ “Y8 a8” “8a 88P’ “Y8 88
88 88 88 8b d8 88 “”
88 88 88 “8a, ,a8" 88 aa
88888888888 88 88 `“YbbdP”' 88 88
Oh no! Not one of these :(
It looks like you’ve run into an error or exception.
Please log an issue via
https://github.com/SalesforceCommerceCloud/b2c-crm-sync/issues.
That’s the best way to engage us. Thank you for your support!

`----------------------------------------------------------------------' [ { “stack”: “DeployFailed: Deploy failed.\n at DeployResultFormatter.display (/Users/neeraj.jain/b2c-crm-sync-master/node_modules/@salesforce/plugin-source/lib/formatters/deployResultFormatter.js:61:19)\n at Deploy.formatResult (/Users/neeraj.jain/b2c-crm-sync-master/node_modules/@salesforce/plugin-source/lib/commands/force/source/deploy.js:127:23)\n at Deploy.run (/Users/neeraj.jain/b2c-crm-sync-master/node_modules/@salesforce/plugin-source/lib/commands/force/source/deploy.js:40:21)\n at processTicksAndRejections (node:internal/process/task_queues:93:5)\n at async Deploy._run (/Users/neeraj.jain/b2c-crm-sync-master/node_modules/@salesforce/command/lib/sfdxCommand.js:81:40)“, “message”: “Deploy failed.“, “name”: “DeployFailed”, “exitCode”: 1, “commandName”: “Deploy”, “code”: “Error” } ]

Thanks Neeraj

chandanrjit commented 2 years ago

It's a valid issue. Better to get high vulnerabilities fixed. All highs are related to glob-parent https://github.com/advisories/GHSA-896r-f27r-55mw. You can manually update the package-lock file for the glob-parent version and get rid of high vulnerability but it may end up in conflict or other dependencies issues. I tried but need to do the setup to test the build and deployment. image

For the error (deployResultFormatter), Can you please check if your nodejs version is as per the recommendation?

Cheers

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

The nodejs version is 15.2.1. I reran the steps from beginning and again failed at the same step. The failure message is not helpful. I can run through the process with you if it helps in resolving the issue.

Thanks

Neeraj

chandanrjit commented 2 years ago

Hi @neeraj-jain01 , Let's connect on this. Cheers

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

I am based in Melbourne, Australia. Current time is 1.30 AM. Let me know as to what time suits you ?

Thanks Neeraj

chandanrjit commented 2 years ago

Hey @neeraj-jain01 , Let's do it tomorrow (15th Jan around 14:00 PM AEDT). google hangout me@chandankumar.dev.Cheers

neeraj-jain01 commented 2 years ago

Hi @chandanrjit , I will be available from 2PM to 3.30 PM. Let us try to identify and resolve the issue. Thanks Neeraj

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

I am available now. I have sent you a meeting invite to your hotmail email address. Please Join.

Thanks Neeraj

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

It appears that you are busy elsewhere. I am signing off from Google Meet Session. Please let me know as to when you are avlbl this weekend or Monday. Thanks

Neeraj

chandanrjit commented 2 years ago

I missing your invite @neeraj-jain01 . Can you send the invite for tomorrow 6PM NZ time?

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

Should I send the invite to chandanroy_07@hotmail.com or any other email address ?

Thanks Neeraj

neeraj-jain01 commented 2 years ago

@chandanrjit , I have sent you an invite for 6 PM NZ time tomorrow. The link is provided below : meet.google.com/sus-qaeb-hom Thanks Neeraj

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

Seems you are busy today. I am signing off from Google Meet. Please let me know the time we can catch up and continue from where we left on Sunday.

Thanks Neeraj

neeraj-jain01 commented 2 years ago

Hi @chandanrjit ,

Can we start back on this issue and deploy b2c CRM sync in my environment?

Thanks Neeraj