SalesforceCommerceCloud / commerce-sdk-isomorphic

Browser & Node.js JavaScript client for B2C Commerce API
https://salesforcecommercecloud.github.io/commerce-sdk-isomorphic/
BSD 3-Clause "New" or "Revised" License
42 stars 20 forks source link

Bump the package size limit to 350kb #95

Closed kevinxh closed 2 years ago

kevinxh commented 2 years ago

The CI is failing on main branch because the exceeded package size limit. (For some reason it didn't complaint on my branch. I'm guessing the dependencies versions are not locked so the result of each npm install gives different dependencies and in turn result in different build?)

Screen Shot 2022-07-14 at 1 59 56 PM

This PR bumps up the size to 350kb to have some room.

(I don't quite understand why we need a limit for the whole package. It makes sense to have the limit for JS but I don't think it matters for the rest of the files like type declarations, READMEs etc. 🤷 Shall we remove this test?)