SalesforceCommerceCloud / commerce-sdk

https://salesforcecommercecloud.github.io/commerce-sdk/
BSD 3-Clause "New" or "Revised" License
149 stars 48 forks source link

fix: resolve linting issues @W-12622010@ #386

Closed joeluong-sfcc closed 1 year ago

joeluong-sfcc commented 1 year ago

This PR fixes linting where npm run lint runs without erroring out. New linting rules were added in .eslintrc.json:

This PR also updates the CI to use npm install --force instead of npm install. This is because there are peer dependency issues between typedoc-plugin-nojekyll and typedoc-plugin-external-module-map, where both have typedoc listed as a peer dependency, but with conflicting versions. typedoc-plugin-nojekyll looks for v0.11.1 of typedoc and typedoc-plugin-external-module-map looks for typedoc with versioning >=0.14 <1.0. Unfortunately upgrading these dependency versions does not resolve this issue as typedoc-plugin-nojekyll is no longer being actively maintained, the last release/commit being 5 years ago.