search

SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
276 stars 125 forks source link

JavaScript heap out of memory with pwa-kit 2.7.0 #1102

Closed axciccu closed 1 year ago

axciccu commented 1 year ago

Summary

With the pwa-kit 2.7.0 that supports node 16, this error appears:

<--- Last few GCs --->

[20144:000001EBD9220D30] 277664 ms: Scavenge 2023.4 (2057.2) -> 2022.2 (2057.2) MB, 4.1 / 0.0 ms (average mu = 0.637, current mu = 0.705) allocation failure [20144:000001EBD9220D30] 278649 ms: Mark-sweep 2066.1 (2099.1) -> 2063.4 (2099.4) MB, 727.3 / 0.1 ms (average mu = 0.472, current mu = 0.311) allocation failure GC in old space requested

<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory 1: 00007FF7C1B3168F v8::internal::CodeObjectRegistry::~CodeObjectRegistry+122159 2: 00007FF7C1ABB456 DSA_meth_get_flags+64118 3: 00007FF7C1ABC4D2 DSA_meth_get_flags+68338 4: 00007FF7C23F3CB4 v8::Isolate::ReportExternalAllocationLimitReached+116 5: 00007FF7C23DE27D v8::SharedArrayBuffer::Externalize+781 6: 00007FF7C228183C v8::internal::Heap::EphemeronKeyWriteBarrierFromCode+1468 7: 00007FF7C227E954 v8::internal::Heap::CollectGarbage+4244 8: 00007FF7C227C2D0 v8::internal::Heap::AllocateExternalBackingStore+2000 9: 00007FF7C2299FE0 v8::internal::FreeListManyCached::Reset+1408 10: 00007FF7C229A695 v8::internal::Factory::AllocateRaw+37 11: 00007FF7C22AC83D v8::internal::FactoryBase::AllocateRawOneByteInternalizedString+109 12: 00007FF7C22AFA69 v8::internal::FactoryBase::NewOneByteInternalizedString+25 13: 00007FF7C209574A v8::internal::String::ToCString+6026 14: 00007FF7C22AC29B v8::internal::FactoryBase::InternalizeStringWithKey<v8::internal::SequentialStringKey >+27 15: 00007FF7C23CBEE4 v8::internal::AstValueFactory::Internalize+164 16: 00007FF7C2074C3E v8::internal::Parser::DoParseProgram+1790 17: 00007FF7C207B244 v8::internal::Parser::ParseProgram+468 18: 00007FF7C206F5D6 v8::internal::parsing::ParseProgram+278 19: 00007FF7C23751C5 v8::internal::Compiler::CompileSharedWithBaseline+1701 20: 00007FF7C2379A9D v8::internal::Compiler::GetWrappedFunction+1213 21: 00007FF7C23D8AF5 v8::ScriptCompiler::CompileFunctionInContext+1637 22: 00007FF7C1AC631A node::OnFatalError+40506 23: 00007FF7C23AE676 v8::internal::Builtins::code_handle+172806 24: 00007FF7C23AE269 v8::internal::Builtins::code_handle+171769 25: 00007FF7C23AE52C v8::internal::Builtins::code_handle+172476 26: 00007FF7C23AE390 v8::internal::Builtins::code_handle+172064 27: 00007FF7C2481A71 v8::internal::SetupIsolateDelegate::SetupHeap+494641 28: 000001EBDAF9A7B2 error: Command failed: node C:\test\pwa-kit-starter-project\app\ssr.js

Steps To Reproduce

Expected result

The component should be modified and the application should work properly.

Actual result

The application crashes with the error above.

System Information (as applicable)

Node version: 16.19.1 (also tried with 16.16.0) pwa-kit version: 2.7.0 Desktop OS: Windows 10

Additional information

Note that I also tried to use the node version 16.16.0 and to add the --noHMR option but the error still occurs.

bfeister commented 1 year ago

@axciccu we're going to need your help working through this. When we released node 16 support, the release was tested by multiple engineers on our side without seeing this issue. Let's start with some more info about your setup

  1. Are you using nvm or n or any other node version manager for having multiple versions of node on your local machine
  2. Have you verified this issue persists after shutting down your computer completely and waiting 10+ seconds before restarting? JavaScript/ node memory heap allocation errors can often be caused by the memory pressure on your computer and fixed by addressing that / closing other programs that are creating memory pressure
axciccu commented 1 year ago

Hi @bfeister these are the answers:

  1. I'm using nvs
  2. Yes, I did it
bfeister commented 1 year ago

I've never heard of nvs before, can you try using nvm as the release was tested with it and see if you still have an issue?

ValentinGurkov commented 1 year ago

We occasionally get this with Node.js 14 pwa-kit 2.30, when the server runs for long enough or we trigger HRM a lot by saving very frequently.

bfeister commented 1 year ago

We have been investigating this extensively internally. Thanks for bringing to our attention

breadadams commented 1 year ago

Have wanted to open an issue about this for a couple of months now, glad to see someone beat me to it 🙂 . If it's of any help we have seen it happening on both macOS and Windows, and it's definitely not specific to 2.7.0 (as mentioned by @ValentinGurkov).

There seems to be a memory leak somewhere which causes the JS heap to run out of memory after a significant amount of hot reloads. All devs on the team get the error numerous times a day (since January, at the least), we're using Node 14.

From what I've seen, increasing Node's memory limit with --max-old-space-size helps, but (obviously) eventually it still runs out of memory.

Additionally, I've been storing some of the errors/stacktraces for when reporting the issue:

Heap error (1) ``` <--- Last few GCs ---> [64177:0x104a0c000] 4082318 ms: Scavenge 4064.7 (4093.8) -> 4059.6 (4093.8) MB, 9.9 / 0.0 ms (average mu = 0.291, current mu = 0.256) allocation failure [64177:0x104a0c000] 4083888 ms: Scavenge 4065.0 (4094.1) -> 4061.4 (4096.1) MB, 7.7 / 0.0 ms (average mu = 0.291, current mu = 0.256) task [64177:0x104a0c000] 4084909 ms: Scavenge (reduce) 4067.9 (4096.1) -> 4062.7 (4097.3) MB, 8.8 / 0.0 ms (average mu = 0.291, current mu = 0.256) allocation failure <--- JS stacktrace ---> FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory 1: 0x101323535 node::Abort() (.cold.1) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 2: 0x1000b65f9 node::Abort() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 3: 0x1000b676f node::OnFatalError(char const*, char const*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 4: 0x100201787 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 5: 0x100201723 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 6: 0x1003af835 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 7: 0x1003b12da v8::internal::Heap::RecomputeLimits(v8::internal::GarbageCollector) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 8: 0x1003aca05 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 9: 0x1003aa330 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 10: 0x1003a9298 v8::internal::Heap::HandleGCRequest() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 11: 0x100365731 v8::internal::StackGuard::HandleInterrupts() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 12: 0x1007059d9 v8::internal::Runtime_StackGuard(int, unsigned long*, v8::internal::Isolate*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 13: 0x100a8ead9 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 14: 0x100a256aa Builtins_InterpreterEntryTrampoline [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] error: Command failed: node /Users/bradadams/project-path/packages/pwa-kit/app/ssr.js npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! pwa-kit@0.0.1 start: `cross-env NODE_ICU_DATA=node_modules/full-icu pwa-kit-dev start` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the pwa-kit@0.0.1 start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /Users/bradadams/.npm/_logs/2023-04-13T22_09_35_545Z-debug.log ```
Heap error (2) ``` <--- Last few GCs ---> [75390:0x104a0c000] 8638934 ms: Scavenge 4069.5 (4095.3) -> 4064.2 (4095.8) MB, 11.2 / 0.0 ms (average mu = 0.245, current mu = 0.211) allocation failure [75390:0x104a0c000] 8638969 ms: Scavenge 4070.3 (4095.8) -> 4065.6 (4097.0) MB, 15.8 / 0.0 ms (average mu = 0.245, current mu = 0.211) allocation failure [75390:0x104a0c000] 8638999 ms: Scavenge 4072.0 (4097.0) -> 4067.0 (4099.0) MB, 13.4 / 0.0 ms (average mu = 0.245, current mu = 0.211) allocation failure <--- JS stacktrace ---> FATAL ERROR: MarkCompactCollector: young object promotion failed Allocation failed - JavaScript heap out of memory 1: 0x101323535 node::Abort() (.cold.1) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 2: 0x1000b65f9 node::Abort() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 3: 0x1000b676f node::OnFatalError(char const*, char const*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 4: 0x100201787 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 5: 0x100201723 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 6: 0x1003af835 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 7: 0x10040b893 v8::internal::EvacuateNewSpaceVisitor::Visit(v8::internal::HeapObject, int) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 8: 0x1003f30fb void v8::internal::LiveObjectVisitor::VisitBlackObjectsNoFail(v8::internal::MemoryChunk*, v8::internal::MajorNonAtomicMarkingState*, v8::internal::EvacuateNewSpaceVisitor*, v8::internal::LiveObjectVisitor::IterationMode) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 9: 0x1003f2c45 v8::internal::FullEvacuator::RawEvacuatePage(v8::internal::MemoryChunk*, long*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 10: 0x1003f2986 v8::internal::Evacuator::EvacuatePage(v8::internal::MemoryChunk*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 11: 0x1004102be v8::internal::PageEvacuationTask::RunInParallel(v8::internal::ItemParallelJob::Task::Runner) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 12: 0x1003ca272 v8::internal::ItemParallelJob::Task::RunInternal() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 13: 0x1003ca6f8 v8::internal::ItemParallelJob::Run() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 14: 0x1003f49f5 void v8::internal::MarkCompactCollectorBase::CreateAndExecuteEvacuationTasks(v8::internal::MarkCompactCollector*, v8::internal::ItemParallelJob*, v8::internal::MigrationObserver*, long) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 15: 0x1003f45f6 v8::internal::MarkCompactCollector::EvacuatePagesInParallel() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 16: 0x1003dfd67 v8::internal::MarkCompactCollector::Evacuate() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 17: 0x1003dd5fb v8::internal::MarkCompactCollector::CollectGarbage() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 18: 0x1003afefb v8::internal::Heap::MarkCompact() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 19: 0x1003ac4e9 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 20: 0x1003aa330 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 21: 0x1003b8a5a v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 22: 0x1003b8ae1 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 23: 0x100381950 v8::internal::FactoryBase::AllocateRawOneByteInternalizedString(int, unsigned int) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 24: 0x1003817f2 v8::internal::FactoryBase::NewOneByteInternalizedString(v8::internal::Vector const&, unsigned int) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 25: 0x1002588d2 v8::internal::SequentialStringKey::AsHandle(v8::internal::Isolate*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 26: 0x1005c8693 v8::internal::StringTable::AddKeyNoResize(v8::internal::Isolate*, v8::internal::StringTableKey*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 27: 0x100255ab4 void v8::internal::AstValueFactory::Internalize(v8::internal::Isolate*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 28: 0x100635113 v8::internal::Parser::DoParseProgram(v8::internal::Isolate*, v8::internal::ParseInfo*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 29: 0x100634651 v8::internal::Parser::ParseProgram(v8::internal::Isolate*, v8::internal::Handle, v8::internal::ParseInfo*, v8::internal::MaybeHandle) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 30: 0x10065d555 v8::internal::parsing::ParseProgram(v8::internal::ParseInfo*, v8::internal::Handle, v8::internal::MaybeHandle, v8::internal::Isolate*, v8::internal::parsing::ReportErrorsAndStatisticsMode) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 31: 0x1002cc3fa v8::internal::(anonymous namespace)::CompileToplevel(v8::internal::ParseInfo*, v8::internal::Handle, v8::internal::MaybeHandle, v8::internal::Isolate*, v8::internal::IsCompiledScope*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 32: 0x1002ce177 v8::internal::Compiler::GetWrappedFunction(v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::Compiler::ScriptDetails const&, v8::ScriptOriginOptions, v8::internal::ScriptData*, v8::ScriptCompiler::CompileOptions, v8::ScriptCompiler::NoCacheReason) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 33: 0x10020c182 v8::ScriptCompiler::CompileFunctionInContext(v8::Local, v8::ScriptCompiler::Source*, unsigned long, v8::Local*, unsigned long, v8::Local*, v8::ScriptCompiler::CompileOptions, v8::ScriptCompiler::NoCacheReason, v8::Local*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 34: 0x1000a863e node::contextify::ContextifyContext::CompileFunction(v8::FunctionCallbackInfo const&) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 35: 0x100272328 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 36: 0x1002718bc v8::internal::MaybeHandle v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::BuiltinArguments) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 37: 0x100271022 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 38: 0x100a8ebb9 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 39: 0x100a25622 Builtins_InterpreterEntryTrampoline [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] error: Command failed: node /Users/bradadams/path-to-project/packages/pwa-kit/app/ssr.js npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! pwa-kit@0.0.1 start: `cross-env NODE_ICU_DATA=node_modules/full-icu pwa-kit-dev start` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the pwa-kit@0.0.1 start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /Users/bradadams/.npm/_logs/2023-04-14T13_53_15_265Z-debug.log ```
Heap error (3) ``` <--- Last few GCs ---> [67687:0x104a0c000] 3952163 ms: Scavenge 4067.4 (4095.6) -> 4061.6 (4095.6) MB, 3.2 / 0.0 ms (average mu = 0.324, current mu = 0.110) allocation failure [67687:0x104a0c000] 3952197 ms: Scavenge 4067.5 (4095.6) -> 4062.9 (4095.9) MB, 10.4 / 0.0 ms (average mu = 0.324, current mu = 0.110) allocation failure [67687:0x104a0c000] 3952225 ms: Scavenge 4069.4 (4095.9) -> 4064.3 (4096.4) MB, 9.2 / 0.0 ms (average mu = 0.324, current mu = 0.110) allocation failure <--- JS stacktrace ---> FATAL ERROR: MarkCompactCollector: young object promotion failed Allocation failed - JavaScript heap out of memory 1: 0x101323535 node::Abort() (.cold.1) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 2: 0x1000b65f9 node::Abort() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 3: 0x1000b676f node::OnFatalError(char const*, char const*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 4: 0x100201787 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 5: 0x100201723 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 6: 0x1003af835 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 7: 0x10040b893 v8::internal::EvacuateNewSpaceVisitor::Visit(v8::internal::HeapObject, int) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 8: 0x1003f30fb void v8::internal::LiveObjectVisitor::VisitBlackObjectsNoFail(v8::internal::MemoryChunk*, v8::internal::MajorNonAtomicMarkingState*, v8::internal::EvacuateNewSpaceVisitor*, v8::internal::LiveObjectVisitor::IterationMode) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 9: 0x1003f2c45 v8::internal::FullEvacuator::RawEvacuatePage(v8::internal::MemoryChunk*, long*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 10: 0x1003f2986 v8::internal::Evacuator::EvacuatePage(v8::internal::MemoryChunk*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 11: 0x1004102be v8::internal::PageEvacuationTask::RunInParallel(v8::internal::ItemParallelJob::Task::Runner) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 12: 0x1003ca272 v8::internal::ItemParallelJob::Task::RunInternal() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 13: 0x1003ca6f8 v8::internal::ItemParallelJob::Run() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 14: 0x1003f49f5 void v8::internal::MarkCompactCollectorBase::CreateAndExecuteEvacuationTasks(v8::internal::MarkCompactCollector*, v8::internal::ItemParallelJob*, v8::internal::MigrationObserver*, long) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 15: 0x1003f45f6 v8::internal::MarkCompactCollector::EvacuatePagesInParallel() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 16: 0x1003dfd67 v8::internal::MarkCompactCollector::Evacuate() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 17: 0x1003dd5fb v8::internal::MarkCompactCollector::CollectGarbage() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 18: 0x1003afefb v8::internal::Heap::MarkCompact() [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 19: 0x1003ac4e9 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 20: 0x1003aa330 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 21: 0x1003b8a5a v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 22: 0x1003b8ae1 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 23: 0x10038024e v8::internal::FactoryBase::NewWeakFixedArrayWithMap(v8::internal::Map, int, v8::internal::AllocationType) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 24: 0x10038c38b v8::internal::Factory::NewTransitionArray(int, int) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 25: 0x100620b36 v8::internal::TransitionsAccessor::Insert(v8::internal::Handle, v8::internal::Handle, v8::internal::SimpleTransitionFlag) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 26: 0x1005c1b0b v8::internal::Map::ConnectTransition(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::SimpleTransitionFlag) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 27: 0x1005c1dd3 v8::internal::Map::CopyReplaceDescriptors(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::TransitionFlag, v8::internal::MaybeHandle, char const*, v8::internal::SimpleTransitionFlag) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 28: 0x1005bca78 v8::internal::Map::CopyAddDescriptor(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Descriptor*, v8::internal::TransitionFlag) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 29: 0x1005bc7c7 v8::internal::Map::CopyWithField(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::PropertyAttributes, v8::internal::PropertyConstness, v8::internal::Representation, v8::internal::TransitionFlag) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 30: 0x1005c34e8 v8::internal::Map::TransitionToDataProperty(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::PropertyAttributes, v8::internal::PropertyConstness, v8::internal::StoreOrigin) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 31: 0x1005b580a v8::internal::LookupIterator::PrepareTransitionToDataProperty(v8::internal::Handle, v8::internal::Handle, v8::internal::PropertyAttributes, v8::internal::StoreOrigin) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 32: 0x10045dfa6 v8::internal::StoreIC::LookupForWrite(v8::internal::LookupIterator*, v8::internal::Handle, v8::internal::StoreOrigin) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 33: 0x10045ed19 v8::internal::StoreIC::UpdateCaches(v8::internal::LookupIterator*, v8::internal::Handle, v8::internal::StoreOrigin) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 34: 0x10045ea93 v8::internal::StoreIC::Store(v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::StoreOrigin) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 35: 0x100463c08 v8::internal::Runtime_StoreIC_Miss(int, unsigned long*, v8::internal::Isolate*) [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] 36: 0x100a8ead9 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node] error: Command failed: node /Users/bradadams/path-to-project/packages/pwa-kit/app/ssr.js npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! pwa-kit@0.0.1 start: `cross-env NODE_ICU_DATA=node_modules/full-icu pwa-kit-dev start` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the pwa-kit@0.0.1 start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /Users/bradadams/.npm/_logs/2023-04-17T22_27_32_989Z-debug.log ```
Complete log from `.npm/_logs/*-debug.log` ``` 0 info it worked if it ends with ok 1 verbose cli [ 1 verbose cli '/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node', 1 verbose cli '/Users/bradadams/.nvm/versions/node/v14.20.0/bin/npm', 1 verbose cli 'run', 1 verbose cli 'start', 1 verbose cli '--' 1 verbose cli ] 2 info using npm@6.14.17 3 info using node@v14.20.0 4 verbose run-script [ 'prestart', 'start', 'poststart' ] 5 info lifecycle pwa-kit@0.0.1~prestart: pwa-kit@0.0.1 6 info lifecycle pwa-kit@0.0.1~start: pwa-kit@0.0.1 7 verbose lifecycle pwa-kit@0.0.1~start: unsafe-perm in lifecycle true 8 verbose lifecycle pwa-kit@0.0.1~start: PATH: /Users/bradadams/.nvm/versions/node/v14.20.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/bradadams/path-to-project/packages/pwa-kit/node_modules/.bin:/Users/bradadams/path-to-project/node_modules/.bin:/Users/bradadams/.nvm/versions/node/v14.20.0/bin:/Users/bradadams/.nvm/versions/node/v10.22.0/bin:/usr/local/bin:/Users/bradadams/.nvm/versions/node/v10.22.0/bin:/Users/bradadams/.rvm/gems/ruby-2.7.0/bin:/Users/bradadams/.rvm/gems/ruby-2.7.0@global/bin:/Users/bradadams/.rvm/rubies/ruby-2.7.0/bin:/Users/bradadams/google-cloud-sdk/bin:/Users/bradadams/.rbenv/shims:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/MacGPG2/bin:/Library/Apple/usr/bin:/usr/local/mysql/bin:/Users/bradadams/.rvm/bin:/Users/bradadams/Library/Android/sdk/emulator:/Users/bradadams/Library/Android/sdk/tools:/Users/bradadams/Library/Android/sdk/tools/bin:/Users/bradadams/Library/Android/sdk/platform-tools 9 verbose lifecycle pwa-kit@0.0.1~start: CWD: /Users/bradadams/path-to-project/packages/pwa-kit 10 silly lifecycle pwa-kit@0.0.1~start: Args: [ 10 silly lifecycle '-c', 10 silly lifecycle 'cross-env NODE_ICU_DATA=node_modules/full-icu pwa-kit-dev start' 10 silly lifecycle ] 11 silly lifecycle pwa-kit@0.0.1~start: Returned: code: 1 signal: null 12 info lifecycle pwa-kit@0.0.1~start: Failed to exec start script 13 verbose stack Error: pwa-kit@0.0.1 start: `cross-env NODE_ICU_DATA=node_modules/full-icu pwa-kit-dev start` 13 verbose stack Exit status 1 13 verbose stack at EventEmitter. (/Users/bradadams/.nvm/versions/node/v14.20.0/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16) 13 verbose stack at EventEmitter.emit (events.js:400:28) 13 verbose stack at ChildProcess. (/Users/bradadams/.nvm/versions/node/v14.20.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14) 13 verbose stack at ChildProcess.emit (events.js:400:28) 13 verbose stack at maybeClose (internal/child_process.js:1088:16) 13 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:296:5) 14 verbose pkgid pwa-kit@0.0.1 15 verbose cwd /Users/bradadams/path-to-project/packages/pwa-kit 16 verbose Darwin 21.6.0 17 verbose argv "/Users/bradadams/.nvm/versions/node/v14.20.0/bin/node" "/Users/bradadams/.nvm/versions/node/v14.20.0/bin/npm" "run" "start" "--" 18 verbose node v14.20.0 19 verbose npm v6.14.17 20 error code ELIFECYCLE 21 error errno 1 22 error pwa-kit@0.0.1 start: `cross-env NODE_ICU_DATA=node_modules/full-icu pwa-kit-dev start` 22 error Exit status 1 23 error Failed at the pwa-kit@0.0.1 start script. 23 error This is probably not a problem with npm. There is likely additional logging output above. 24 verbose exit [ 1, true ] ```
kevinxh commented 1 year ago

we have a solution that we are testing at the moment -> https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1155

kevinxh commented 1 year ago

The change is merged. This change will most likely go out with the upcoming V3 release.

axciccu commented 10 months ago

Just to add that this issue is still present in the version 3.1.0 of pwa-kit with node 18.12.0 and npm 8.19.2.

shethj commented 10 months ago

@axciccu Thank you for pointing that out. We're looking into the issue.