search

SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
285 stars 135 forks source link

[BUG] pwa-kit demo site (https://pwa-kit.mobify-storefront.com/) is not accessible #1353

Open dannya opened 1 year ago

dannya commented 1 year ago

Summary

pwa-kit demo site (https://pwa-kit.mobify-storefront.com/) is not accessible. A first pass with the Lighthouse audit tool in Google Chrome results in a surprisingly low score of 89 for accessibility, and a few easily fixable issues.

Furthermore, manual testing using keyboard-only navigation and the NVDA screen reader reveals lots more issues, especially with the header. For example, the down arrows next to the headings in the mega menu do not announce their purpose using a screen reader, and they don't even function to open the menu when using a keyboard.

Steps To Reproduce

Run a Lighthouse audit Try to use the mega menu using only a keyboard. Try to use the mega menu non-visually, using a screen reader.

Describe what should have happened.

This is all basic stuff that should work and have been caught already in your development process.

Actual result

image

Additional information

What is the level of accessibility awareness of your development team?

bfeister commented 1 year ago

Hi @dannya ... thanks for the audit. We have an internal audit and a plan to improve the a11y standing of the product in 248.

That being said, the historical on the product is that it was never assumed that this UI would be implemented without alteration by customers. Thus, since it was an example starting point, the focus was on functionality with an explicit assumption that customers will dramatically change the site (bringing along many changes that impact a11y and require changes that we can't predict in the base template recommendation).

However, we've recently pivoted to assuming that the base template is "less throwaway" than it has been in the past, so we've allocated time to remediation.

dannya commented 1 year ago

@bfeister thanks for your quick and detailed reply.

Is 248 a version number? Is there a public roadmap available?

bfeister commented 1 year ago

248 is a Release cycle. Salesforce works in 4 month work units. The upcoming (roughly August ~ December, 2023) timeframe is when work is slated for.