SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
283 stars 130 forks source link

@W-15621253 Initial Store Locator Implementation #1827

Closed jeremy-jung1 closed 3 months ago

jeremy-jung1 commented 3 months ago

Description

W-15621253

This is the initial Store Locator implementation, which is without pagination and linking of geolocation web API. The initial implementation includes:

  1. the handling of manual geolocation input
  2. default country and postal code and user specified store locator countries
  3. the listing of corresponding stores sorted by distance away
  4. mobile view
  5. a store locator page, on top of the modal, that can be navigated to via URL for SEO

The PR will merge into a store locator base branch, to which subsequent PRs will be merged until the store locator is ready for shipping. Subsequent PRs will link the geolocation web API to the store locator and enable pagination for the store locator.

Types of Changes

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

You must check off all items in one of the follow two lists:

or...

Localization

vmarta commented 3 months ago

@jeremy-jung1 FYI I've left some comments. But I see that you've just made new code changes. I'll review them later at another time.

jeremy-jung1 commented 3 months ago

Before deleting the translations in this PR for professional translation, I took a screenshot of German locale store locator to show that the store locator is translatable. Screenshot 2024-06-13 at 12 44 12 PM

vcua-mobify commented 3 months ago

Not a part of this ticket, but I would be interested in seeing how we handle saving the shopper's selected store in the future since it might have some implication on hybrid (ie. how do we share the selected store from PWA to SFRA?).

Could you loop me in once we get to that part of the epic?