Closed adamraya closed 3 months ago
@adamraya how about the console warnings from commerce-sdk-react
? The package has no dependency on pwa-kit-dev
, so we probably don't want to import its logger in this case.
https://github.com/SalesforceCommerceCloud/pwa-kit/blob/c8aa0c0525a9e6e3292dc01fdd36d8c80dd26387/packages/commerce-sdk-react/src/auth/index.ts#L405-L409
But perhaps we can make CommerceApiProvider to receive an optional logger instance? If the logger is provided, then commerce-sdk-react would use it. Otherwise, fall back to console.warn
.
Description
Follow-up PR from https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1822 Replacing all the
console
statements in PWA Kit packages with the equivalentlogger
.Types of Changes
Changes
console
statements in PWA Kit packages printing logs on the server/client with the equivalentlogger
.How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization