SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
276 stars 124 forks source link

Consistent Logs - Add logger to pwa-kit-create-app (@W-15832306@) #1855

Closed adamraya closed 2 weeks ago

adamraya commented 2 weeks ago

Description

Follow up PR to https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1822 adding the logger to pwa-kit-create-app

Types of Changes

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

General

Accessibility Compliance

You must check off all items in one of the follow two lists:

or...

Localization

vmarta commented 2 weeks ago

NOTE: on how to test-drive the PR, generating a project (with node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir ~/generated-project-demo2) would probably not work accurately because version 3.6.0-dev is already published to npm.

vcua-mobify commented 2 weeks ago

I generated an app but it didn't have the namespaced logs. Probably because of what @vmarta mentioned

adamraya commented 2 weeks ago

@vcua-mobify: Yes, I forgot to mention in the instructions that I temporarily bumped the versions before generating the project to consume the changes from the local NPM repository instead of NPM.

Thanks for making those changes in the development, @vmarta. I verified that now following the test steps, we get the expected output.