SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
276 stars 124 forks source link

fix e2e tests #1860

Closed alexvuong closed 1 week ago

alexvuong commented 1 week ago

Description

Fix E2e tests for product tile since the e2e env is using different settings and instance which affects the products on PLP

Related PR: #1808

Types of Changes

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

You must check off all items in one of the follow two lists:

or...

Localization

alexvuong commented 1 week ago

LGTM. Question: Why do the environments have different data? Are the tests now using the default SFRA demo data?

the data set on instances are the same, but the data returned are different because e2e tests are tested on a generated project which uses overrides, and the settings for PLP is to fetch 3 items instead of 25 like current retail app. See here