SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
276 stars 124 forks source link

@W-15628148 Implement Pagination and Integrate Web Geolocation API #1862

Open jeremy-jung1 opened 1 week ago

jeremy-jung1 commented 1 week ago

W-15628148 and W-15621326

Description

Added "Load More" button functionality to store locator and integrated native web geolocation API to "Use my Location" function. Made default of country selector, if defined in constants.js, to show "Select a country". Updated UI text to remove distance and show information on geolocation.

Types of Changes

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

You must check off all items in one of the follow two lists:

or...

Localization

salesforce-cla[bot] commented 1 week ago

Thanks for the contribution! It looks like @jeremy-jung1 is an internal user so signing the CLA is not required. However, we need to confirm this.

kevinxh commented 1 week ago

For some reason the linter isn't working, i'm surprised there is var in the code and tests are passing... let's only use let or const. No var in the code base.

vmarta commented 5 days ago

When I opened the modal, I could see some errors/warnings in the browser console. Let's fix them, because otherwise that won't leave a good impression to other developers.

Arc 2024-07-02 at 14 40 36