SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
276 stars 124 forks source link

change default node version to 20.x #1867

Closed kevinxh closed 1 week ago

kevinxh commented 1 week ago

Description

This PR changes the default node.js version from 18.x to 20.x

Types of Changes

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

You must check off all items in one of the follow two lists:

or...

Localization

adamraya commented 1 week ago

We may want to update the default Node version in GA as well.

https://github.com/SalesforceCommerceCloud/pwa-kit/blob/5609322ff19a78e542a7a1178f1caacc9b0618f1/.github/workflows/test.yml#L144

and here:

https://github.com/SalesforceCommerceCloud/pwa-kit/blob/5609322ff19a78e542a7a1178f1caacc9b0618f1/.github/workflows/test.yml#L49