This PR adds back in tests that were skipped due to some updates that broke those tests. There is still a unit test being skipped, remove from cart test, but I couldn't find a good way to make it pass as it consistently timed out for me.
Types of Changes
[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)
Breaking changes include:
Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json
Changes
(change1)
How to Test-Drive This PR
git checkout ju/fix-cart-tests
cd packages/template-retail-react-app
npm run test 'app/pages/cart/index.test.js --coverage=false'
Observe that the unit test passes and there is only 1 skipped test (remove from cart test)
Checklists
General
[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)
Accessibility Compliance
You must check off all items in one of the follow two lists:
[ ] There are no changes to UI
or...
[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
Description
This PR adds back in tests that were skipped due to some updates that broke those tests. There is still a unit test being skipped, remove from cart test, but I couldn't find a good way to make it pass as it consistently timed out for me.
Types of Changes
Changes
How to Test-Drive This PR
git checkout ju/fix-cart-testscd packages/template-retail-react-appnpm run test 'app/pages/cart/index.test.js --coverage=false'Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization