SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
283 stars 130 forks source link

Run changelog-check only on PR context (@W-16164410@) #2006

Closed adamraya closed 3 weeks ago

adamraya commented 3 weeks ago

Description

PR follow up of https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1948 that simplifies the GA changelog check to only run in the PR context. It also uses the values available in GA without the need to use the API calls.

Types of Changes

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

Check the GA builds for the tested scenarios:

  1. PASS Test Commit with changes on non-public packages: https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2006/commits/7bd1d2364de79415a27ee951832bb40d54da49d0

  2. PASS Test Commit without updating the Changelog.md file and the skip changelog label: https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2006/commits/af131f09b8b9b98bab53ec628a2e57b853c02063

  3. FAIL Test Commit without updating the Changelog.md file: https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2006/commits/7fecf148a49d245bafa71c5565b6bb85ca99ea53

Checklists

General

Accessibility Compliance

You must check off all items in one of the follow two lists:

or...

Localization