search

SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
284 stars 134 forks source link

Add support for simple products / variation groups #202

Open hnestmann opened 2 years ago

hnestmann commented 2 years ago

In order to speed up projects with any type of customer data set, we should add support to the search for different product types, such as simple products and variation groups

Simple products can be found in SFRA electronics category Variations groups e.g. 42416786-3M

https://github.com/SalesforceCommerceCloud/pwa-kit/blob/915bf3e9bceb1fda96279c0b019d26bf108f9470/packages/pwa/app/pages/product-list/index.jsx#L553

uip-robot-zz commented 2 years ago

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

kevinxh commented 2 years ago

Hey @hnestmann ! Thank you for bringing this up. The PWA currently doesn't support simple products and variation group and the team is aware of the lack of feature. It's on our roadmap to add support for other product types.

dev-niko commented 2 years ago

Hey @hnestmann ! Thank you for bringing this up. The PWA currently doesn't support simple products and variation group and the team is aware of the lack of feature. It's on our roadmap to add support for other product types.

Hi @kevinxh, what do you mean exactly by "doesn't support"? I just added "product" to the refine string and it works. I see all Products from the category and iam able to buy them.

searchParams.refine.push('htype=master|product')

kevinxh commented 2 years ago

@dev-niko by "doesn't support", i mean it's not implemented/tested. You could update the api call to include type product, however, the data structure for those type of products might not be correctly handled on pages like product detail page, you might run into issues. Such scenarios are not tested. You can certainly give it a try.

johnboxall commented 2 years ago

Here is a PR that demonstrates how you might approach adding support for more product types: https://github.com/SalesforceCommerceCloud/pwa-kit/pull/629

echessman commented 1 year ago

Hello @hnestmann, we are working on this for the first half of 2023!

bfeister commented 11 months ago

Updating this thread as it's been a while. We still plan on adding support for simple products, but unfortunately have not found the time to address this yet. We hope to do so soon.