SalesforceCommerceCloud / pwa-kit

React-based JavaScript frontend framework to create a progressive web app (PWA) storefront for Salesforce B2C Commerce.
https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pwa-kit-overview.html
BSD 3-Clause "New" or "Revised" License
285 stars 138 forks source link

@W-12627216@ Mobile account menu a11y fixes #2059

Closed vcua-mobify closed 1 month ago

vcua-mobify commented 1 month ago

This is a follow up PR to #1884

This PR contains a couple of a11y fixes for the mobile view's My Account page dropdown menu

There is also some styling changes so that the header is better aligned with the menu items and to make all 'My Account' labels consistent.

Before: Screenshot 2024-10-07 at 5 03 24 PM

After: Screenshot 2024-10-07 at 5 04 36 PM

Testing these changes:

alexvuong commented 1 month ago

Unrelated to this PR, but I noticed an AppOrigin line in the header.

Did we intentionally add this line? If not, do you think we can remove it in this PR?

https://github.com/SalesforceCommerceCloud/pwa-kit/blob/6630ee14e01b36e8ad8cedcba069dd58f335b5be/packages/template-retail-react-app/app/components/_app/index.jsx#L277

oh sorry it was from my PR for testing. @vcua-mobify If you can, please help remove it.

vcua-mobify commented 1 month ago

@alexvuong @adamraya The extra AppOrigin {appOrigin} has been removed!