search

SalesforceCommerceCloud / sfcc-ci

Salesforce Commerce Cloud CLI
https://npmjs.com/package/sfcc-ci
BSD 3-Clause "New" or "Revised" License
231 stars 93 forks source link

Self-signed Certificates #255

Closed t-s-s closed 3 years ago

t-s-s commented 3 years ago

https://github.com/SalesforceCommerceCloud/sfcc-ci/blob/1199c9d1ca67ba2f27d2517b7ec4647bd1667594/lib/webdav.js#L37

Shouldn't this be configurable in the command line interface not just via dw.json

I noticed there is a --selfsigned option but it is ignored.

My understanding is that we should be generating the client certificate and signing it with the key provided by Salesforce rather than using the master certificate provided by SFCC even if it is for CI/CD.

https://documentation.b2c.commercecloud.salesforce.com/DOC1/topic/com.demandware.dochelp/content/b2c_commerce/topics/site_development/b2c_creating_and_using_certificates_for_code_deployment.html

tobiaslohr commented 3 years ago

Hi, thanks for raising this. I don't see a reason, why it should only be supported via dw.json. It should be supported via global flag --selfsigned. Do you mind submitting a PR for this?