search

SalesforceLabs / survey-force

85 stars 61 forks source link

New Security Settings for Spring and Summer 2020 #57

Closed gfuller30 closed 4 years ago

gfuller30 commented 4 years ago

Part of the setup instructions are: "Create a public group and add the survey site user." and "Grant read access to case and contact to this group by creating 2 sharing rules."

As I understand it, the problem is you can no longer add an unauthenticated site user to a public group. Does your latest update address this issue?

Also, the setup instructions related to guest users and the "Secure guest user record access" checkbox says as follows regarding settings:

Surveys: Read, View All (Because Guest user need to see an existing record) Survey Questions: Read, View All, Modify All (Because Guest user need to see and modify an existing record) Survey Question Responses: Read, Create (Because Guest user need to create a new record but does NOT need access to existing record) Surveys Taken: Read, View All, Modify All (Because Guest user need to see and modify an existing record))

While these settings are possible now, my understanding is that in Summer of 2020, the "view all" and "modify all" data checkbozes will be removed from the site guest user.

I am really interested in using SurveyForce as we currently using Timba Surveys and the new settings have completely broken it. There is no longer any support for Timba Surveys.

jrattanpal commented 4 years ago

Good questions

Yes, my update should be able to get around that issue. Although I fixed it for Contact only and may need to fix it for Case too.

As for View All, Modify All, that is only needed because Guest user is seeing survey created by internal users.

I have to test it but I think solution for this is to make Guest User owner of that Survey record. Then you can create some context sharing rules to share those surveys with a public group and add internal roles to that group. Can you test it and let me know if that works?

If that doesn't work then I may need to check if there is another solution. If not then this maybe the end of this wonderful product (but I really hope not)

gfuller30 commented 4 years ago

Thanks for the speedy response. I’m sure you know way more about this than I do. As I understand it, guest users can no longer be owners. Also, you can’t add guest users to public groups any longer.

That said, I’d be happy to install this in my sandbox and test it out with the new settings and then keep you in the loop as to problems I find. Is that workable for you?

Gary Fuller IT Coordinator Center for Aquatic Sciences www.aquaticsciences.org

On Feb 20, 2020, at 12:45 PM, jrattanpal notifications@github.com wrote:



Good questions

Yes, my update should be able to get around that issue. Although I fixed it for Contact only and may need to fix it for Case too.

As for View All, Modify All, that is only needed because Guest user is seeing survey created by internal users.

I have to test it but I think solution for this is to make Guest User owner of that Survey record. Then you can create some context sharing rules to share those surveys with a public group and add internal roles to that group. Can you test it and let me know if that works?

If that doesn't work then I may need to check if there is another solution. If not then this maybe the end of this wonderful product (but I really hope not)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4X4S4CVOYR5SC4NMW3RD26UVA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPMYYI#issuecomment-589220961, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4WMKJFEZFGEGTRVQO3RD26UVANCNFSM4KYTC2JA.

jrattanpal commented 4 years ago

You can assign Survey record to Guest user. That will ensure you don't need to have assign View/Modify All permissions to guest users.

I tested it and it works so this is great news. But you need to test all the steps to be 100% sure.

Yes, it'd be great if you can test this and let me know if you come across any issues

gfuller30 commented 4 years ago

That is good news. I will uninstall timba from our sandbox and install this. I’ll let you know if I run into any problems.

Gary Fuller IT Coordinator Center for Aquatic Sciences www.aquaticsciences.org

On Feb 20, 2020, at 2:18 PM, jrattanpal notifications@github.com wrote:



You can assign Survey record to Guest user. That will ensure you don't need to have assign View/Modify All permissions to guest users.

I tested it and it works so this is great news. But you need to test all the steps to be 100% sure.

Yes, it'd be great if you can test this and let me know if you come across any issues

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VYERPQERX2225M6CDRD3JONA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPWV4Q#issuecomment-589261554, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4TBY6SX5KUH6F632UDRD3JONANCNFSM4KYTC2JA.

jarrods123 commented 4 years ago

We currently have the "Secure guest user record access" Checkbox enabled in our sandbox org, and the follow guest user profile permissions are working for contact merge and external site guest.

-- Surveys: Read, View All -- Survey Questions: Read, View All, Modify All -- Survey Question Responses: Read, Create -- Surveys Taken: Read, View All, Modify (needs edit / create for fields as well) All -- Contact - Read Only

gfuller30 commented 4 years ago

That is the correct behavior for now. But according to the guidelines, as I understand them, in the summer 2020 release the “view all” and “modify all” checkboxes will be disabled for all site guest users. That is why I am bringing this concern up now because I don’t want our users to start creating surveys like they did for a timba Surveys and then in 3 months not be able to use it because of the “view all” and “modify all” restriction that will be enforced.

Gary Fuller IT Coordinator Center for Aquatic Sciences www.aquaticsciences.org

On Feb 20, 2020, at 6:24 PM, jarrods123 notifications@github.com wrote:



We currently have the "Secure guest user record access" Checkbox enabled in our sandbox org, and the follow guest user profile permissions are working for contact merge and external site guest.

-- Surveys: Read, View All -- Survey Questions: Read, View All, Modify All -- Survey Question Responses: Read, Create -- Surveys Taken: Read, View All, Modify (needs edit / create for fields as well) All -- Contact - Read Only

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4S6UDTG7PRRHOZF3BDRD4GKXA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMQ2ASQ#issuecomment-589406282, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4UTJYLDWTLDEB5RSHTRD4GKXANCNFSM4KYTC2JA.

jrattanpal commented 4 years ago

I tested new permissions where you don't need to assign VIew/Modify all permissions.

I have added a 4th point in the readme file (https://github.com/SalesforceLabs/survey-force) that talks about alternative without these permissions.

I have tested the Guest access (but not the access to internal teams).

gfuller30 commented 4 years ago

Thanks, I did see that last night as I was installing SurveyForce. I’m going to try the setup and configuration sometime tomorrow. Thanks for all of your assistance with this!

Gary Fuller IT Coordinator Center for Aquatic Sciences www.aquaticsciences.org

On Feb 21, 2020, at 9:22 AM, jrattanpal notifications@github.com wrote:



I tested new permissions where you don't need to assign VIew/Modify all permissions.

I have added a 4th point in the readme file (https://github.com/SalesforceLabs/survey-force) that talks about alternative without these permissions.

I have tested the Guest access (but not the access to internal teams).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4WU3NNU6HV57JXUZSTRD7PQPA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMS3H3A#issuecomment-589673452, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4XJDQV2I7466HAYBZDRD7PQPANCNFSM4KYTC2JA.

jrattanpal commented 4 years ago

Hi,

I can't tell you why it's not working without looking at it. I tested it in my org and it worked with multiple combinations. When I removed all permissions, I saw the error same as you. Then I made Guest user owner of that record and it worked without any change.

If you can share debug logs then maybe we can find something there.

On Sun, Feb 23, 2020 at 6:28 PM jarrods123 notifications@github.com wrote:

I'm running the current permission settings(Secure guest user access) for site guest user profile and am still hitting the login screen when trying to access a survey. The survey owner is also being set to the guest profile (survey being created through a flow and owner set at survey creation).

Sharing settings Survey - External Public Read/Write Survey Taken - External Public Read/Write

Profile Object Settings Survey - Read Survey Question - Read Survey Question Responses - Read, Create Survey Responses - Read, Create, Edit Surveys Taken - Read, Create, Edit

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLALC365OXSWTSSLFZ3REMBB5A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWKS7Y#issuecomment-590129535, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6HLBFPQ73ZTUXVMOCSCDREMBB5ANCNFSM4KYTC2JA .

jrattanpal commented 4 years ago

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

gfuller30 commented 4 years ago

My apologies. I had meant to test this out in our Sandbox. I will do my best to try these steps out this evening and let you know.

From: jrattanpal notifications@github.com Sent: Thursday, February 27, 2020 12:00 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com Cc: Gary Fuller GFuller@aquaticsciences.org; Author author@noreply.github.com Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VA4J3KKSVKBM3U2ZTRE7WSRA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDUEA#issuecomment-592067088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4VJK4PRAGWRWQ5ZWR3RE7WSRANCNFSM4KYTC2JA.

jrattanpal commented 4 years ago

Make sure to test new steps that I posted today. The old method of view/modify all or changing owner won't work. Newer method is actually very simple; need to create 1 sharing rule using new field I added to Survey__c today (of course you need to make sure that field is true for existing surveys if you want to expose those but that's easily doable)

On Thu, Feb 27, 2020 at 1:17 PM gfuller30 notifications@github.com wrote:

My apologies. I had meant to test this out in our Sandbox. I will do my best to try these steps out this evening and let you know.

From: jrattanpal notifications@github.com Sent: Thursday, February 27, 2020 12:00 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com Cc: Gary Fuller GFuller@aquaticsciences.org; Author < author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VA4J3KKSVKBM3U2ZTRE7WSRA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDUEA#issuecomment-592067088>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AD2XQ4VJK4PRAGWRWQ5ZWR3RE7WSRANCNFSM4KYTC2JA>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLFT52YE473JLDVW6UTRE77S7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFMMGY#issuecomment-592102939, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6HLB72AIQQHLQBNWMIVLRE77S7ANCNFSM4KYTC2JA .

gfuller30 commented 4 years ago

Will do.

Gary Fuller IT Coordinator Center for Aquatic Sciences www.aquaticsciences.org

On Feb 27, 2020, at 1:51 PM, jrattanpal notifications@github.com wrote:

Make sure to test new steps that I posted today. The old method of view/modify all or changing owner won't work. Newer method is actually very simple; need to create 1 sharing rule using new field I added to Survey__c today (of course you need to make sure that field is true for existing surveys if you want to expose those but that's easily doable)

On Thu, Feb 27, 2020 at 1:17 PM gfuller30 notifications@github.com wrote:

My apologies. I had meant to test this out in our Sandbox. I will do my best to try these steps out this evening and let you know.

From: jrattanpal notifications@github.com Sent: Thursday, February 27, 2020 12:00 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com Cc: Gary Fuller GFuller@aquaticsciences.org; Author < author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VA4J3KKSVKBM3U2ZTRE7WSRA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDUEA#issuecomment-592067088>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AD2XQ4VJK4PRAGWRWQ5ZWR3RE7WSRANCNFSM4KYTC2JA>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLFT52YE473JLDVW6UTRE77S7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFMMGY#issuecomment-592102939, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6HLB72AIQQHLQBNWMIVLRE77S7ANCNFSM4KYTC2JA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4W6YCMZDX6QKGMF3STRFADR7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFQEDQ#issuecomment-592118286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4WHB37JSWWKFVZTM5LRFADR7ANCNFSM4KYTC2JA.

gfuller30 commented 4 years ago

Hi,

I did the setup steps. It works fine internally, but not with the guest user site. I think this is because I was unable to create a Sharing rule on Survey__c. You said there was a new field added, but I did not find a Boolean true/false field in available in Sharing. I then thought that maybe I needed to install the app again to take advantage of the new field. It would not let me install it again or upgrade because I think it is the same version number.

From: jrattanpal notifications@github.com Sent: Thursday, February 27, 2020 1:51 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com Cc: Gary Fuller GFuller@aquaticsciences.org; Author author@noreply.github.com Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

Make sure to test new steps that I posted today. The old method of view/modify all or changing owner won't work. Newer method is actually very simple; need to create 1 sharing rule using new field I added to Survey__c today (of course you need to make sure that field is true for existing surveys if you want to expose those but that's easily doable)

On Thu, Feb 27, 2020 at 1:17 PM gfuller30 notifications@github.com<mailto:notifications@github.com> wrote:

My apologies. I had meant to test this out in our Sandbox. I will do my best to try these steps out this evening and let you know.

From: jrattanpal notifications@github.com<mailto:notifications@github.com> Sent: Thursday, February 27, 2020 12:00 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com<mailto:survey-force@noreply.github.com> Cc: Gary Fuller GFuller@aquaticsciences.org<mailto:GFuller@aquaticsciences.org>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VA4J3KKSVKBM3U2ZTRE7WSRA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDUEA#issuecomment-592067088>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AD2XQ4VJK4PRAGWRWQ5ZWR3RE7WSRANCNFSM4KYTC2JA>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLFT52YE473JLDVW6UTRE77S7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFMMGY#issuecomment-592102939, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6HLB72AIQQHLQBNWMIVLRE77S7ANCNFSM4KYTC2JA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4W6YCMZDX6QKGMF3STRFADR7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFQEDQ#issuecomment-592118286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2XQ4WHB37JSWWKFVZTM5LRFADR7ANCNFSM4KYTC2JA.

wahoobie commented 4 years ago

I just wanted to say thank you for the continued conversations and efforts here. I am on our own code branch of Survey Force from some time ago but the tips on ViewSurveyControllerWithoutSharing.cls usage was what I needed to support the Guest User Access restriction. That enabled with the sharing rule and also a change we made a few weeks ago on the owner for the surveys is all working as needed now. Thank you! Christopher - Snow Companies

On Thu, Feb 27, 2020 at 6:50 PM gfuller30 notifications@github.com wrote:

Hi,

I did the setup steps. It works fine internally, but not with the guest user site. I think this is because I was unable to create a Sharing rule on Survey__c. You said there was a new field added, but I did not find a Boolean true/false field in available in Sharing. I then thought that maybe I needed to install the app again to take advantage of the new field. It would not let me install it again or upgrade because I think it is the same version number.

From: jrattanpal notifications@github.com Sent: Thursday, February 27, 2020 1:51 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com Cc: Gary Fuller GFuller@aquaticsciences.org; Author < author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

Make sure to test new steps that I posted today. The old method of view/modify all or changing owner won't work. Newer method is actually very simple; need to create 1 sharing rule using new field I added to Survey__c today (of course you need to make sure that field is true for existing surveys if you want to expose those but that's easily doable)

On Thu, Feb 27, 2020 at 1:17 PM gfuller30 <notifications@github.com mailto:notifications@github.com> wrote:

My apologies. I had meant to test this out in our Sandbox. I will do my best to try these steps out this evening and let you know.

From: jrattanpal <notifications@github.com<mailto: notifications@github.com>> Sent: Thursday, February 27, 2020 12:00 PM To: SalesforceLabs/survey-force <survey-force@noreply.github.com<mailto: survey-force@noreply.github.com>> Cc: Gary Fuller <GFuller@aquaticsciences.org<mailto: GFuller@aquaticsciences.org>>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VA4J3KKSVKBM3U2ZTRE7WSRA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDUEA#issuecomment-592067088>,

or unsubscribe<

https://github.com/notifications/unsubscribe-auth/AD2XQ4VJK4PRAGWRWQ5ZWR3RE7WSRANCNFSM4KYTC2JA>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLFT52YE473JLDVW6UTRE77S7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFMMGY#issuecomment-592102939>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABV6HLB72AIQQHLQBNWMIVLRE77S7ANCNFSM4KYTC2JA>

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4W6YCMZDX6QKGMF3STRFADR7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFQEDQ#issuecomment-592118286>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AD2XQ4WHB37JSWWKFVZTM5LRFADR7ANCNFSM4KYTC2JA>.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ADJFTD2OJXF24GUWLM2535LRFBGWBA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGM6KA#issuecomment-592236328, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJFTD2CU7O434FAQR265YDRFBGWBANCNFSM4KYTC2JA .

jrattanpal commented 4 years ago

I am glad it’s working now.

For the owner, please ignore my comment. You do not (should not) need to change survey owner to guest user. All you need is that sharing rule with proper permissions.

As for other changes, as you found out, I made many changes in the code in this repo. At some point, you should look into merging changes from this branch to your branch if/as needed (of course make sure to thoroughly test in sandbox).

On Thu, Feb 27, 2020 at 8:05 PM wahoobie notifications@github.com wrote:

I just wanted to say thank you for the continued conversations and efforts here. I am on our own code branch of Survey Force from some time ago but the tips on ViewSurveyControllerWithoutSharing.cls usage was what I needed to support the Guest User Access restriction. That enabled with the sharing rule and also a change we made a few weeks ago on the owner for the surveys is all working as needed now. Thank you! Christopher - Snow Companies

On Thu, Feb 27, 2020 at 6:50 PM gfuller30 notifications@github.com wrote:

Hi,

I did the setup steps. It works fine internally, but not with the guest user site. I think this is because I was unable to create a Sharing rule on Survey__c. You said there was a new field added, but I did not find a Boolean true/false field in available in Sharing. I then thought that maybe I needed to install the app again to take advantage of the new field. It would not let me install it again or upgrade because I think it is the same version number.

From: jrattanpal notifications@github.com Sent: Thursday, February 27, 2020 1:51 PM To: SalesforceLabs/survey-force survey-force@noreply.github.com Cc: Gary Fuller GFuller@aquaticsciences.org; Author < author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

Make sure to test new steps that I posted today. The old method of view/modify all or changing owner won't work. Newer method is actually very simple; need to create 1 sharing rule using new field I added to Survey__c today (of course you need to make sure that field is true for existing surveys if you want to expose those but that's easily doable)

On Thu, Feb 27, 2020 at 1:17 PM gfuller30 <notifications@github.com mailto:notifications@github.com> wrote:

My apologies. I had meant to test this out in our Sandbox. I will do my best to try these steps out this evening and let you know.

From: jrattanpal <notifications@github.com<mailto: notifications@github.com>> Sent: Thursday, February 27, 2020 12:00 PM To: SalesforceLabs/survey-force <survey-force@noreply.github.com <mailto: survey-force@noreply.github.com>> Cc: Gary Fuller <GFuller@aquaticsciences.org<mailto: GFuller@aquaticsciences.org>>; Author < author@noreply.github.commailto:author@noreply.github.com> Subject: Re: [SalesforceLabs/survey-force] New Security Settings for Spring and Summer 2020 (#57)

I have submitted some changes today which should fix this.

I have also updated readme file with updated steps on how this should be done going forward.

try this and let me know if it doesn't work (In the Sharing records area, give it some time to apply sharing rules)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4VA4J3KKSVKBM3U2ZTRE7WSRA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFDUEA#issuecomment-592067088 ,

or unsubscribe<

https://github.com/notifications/unsubscribe-auth/AD2XQ4VJK4PRAGWRWQ5ZWR3RE7WSRANCNFSM4KYTC2JA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLFT52YE473JLDVW6UTRE77S7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFMMGY#issuecomment-592102939 ,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABV6HLB72AIQQHLQBNWMIVLRE77S7ANCNFSM4KYTC2JA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<

https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=AD2XQ4W6YCMZDX6QKGMF3STRFADR7A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFQEDQ#issuecomment-592118286 , or unsubscribe<

https://github.com/notifications/unsubscribe-auth/AD2XQ4WHB37JSWWKFVZTM5LRFADR7ANCNFSM4KYTC2JA .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ADJFTD2OJXF24GUWLM2535LRFBGWBA5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGM6KA#issuecomment-592236328 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADJFTD2CU7O434FAQR265YDRFBGWBANCNFSM4KYTC2JA

.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/SalesforceLabs/survey-force/issues/57?email_source=notifications&email_token=ABV6HLGJSVDAQDKF372D2NTRFBPO3A5CNFSM4KYTC2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGSE5Y#issuecomment-592257655, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6HLB3PLY2I2FGHVMXZ5DRFBPO3ANCNFSM4KYTC2JA .

--

Jaswinder Rattanpal www.rattanpal.com