search

SalesforceLabs / survey-force

88 stars 63 forks source link

Refactor all code for efficiency and new API version #76

Closed dschach closed 4 years ago

dschach commented 4 years ago

I have updated all the code to latest API (with required tests being moved to new classes). Fixed unnecessary global modifiers, variables in the wrong place, unused variables, and more. This project is ready for SFDX now. I deleted the src folder because it is unnecessary - people can install from the appropriate folder in force-app. As this is unmanaged, deploying on top of existing (unmodified) code won't be an issue; users should delete unnecessary classes like Message, ReportFinderUtil, etc.

jrattanpal commented 4 years ago

@dschach

This is huge. Thank you!

Can you make the changes to account for latest changes made to this repo? (I made some changes this morning too)

I will need to test it to make sure it all works and is valid for Security Review (although I am sure you kept that in mind).

dschach commented 4 years ago

Closing pull request and resubmitting to take into account recent changes. The new pull request can overwrite the existing repository. Of note, we can delete the src folder entirely, as it should be maintained in force-app folder.