Refactor all code for security and new API version - Githubissues

SalesforceLabs / survey-force

85 stars 61 forks source link

Refactor all code for security and new API version #77

Closed dschach closed 4 years ago

dschach commented 4 years ago

Resubmitted to allow for recent changes

I have updated all the code to latest API (with required tests being moved to new classes). Fixed unnecessary global modifiers, variables in the wrong place, unused variables, and more. This project is ready for SFDX now. I deleted the src folder because it is unnecessary - people can install from the appropriate folder in force-app. As this is unmanaged, deploying on top of existing (unmodified) code won't be an issue; users should delete unnecessary classes like Message, ReportFinderUtil, etc.

jrattanpal commented 4 years ago

Sounds good. I have pulled it locally. Let me test it too (2 sets of eyes) and will submit to master once ready.

Thanks again! This is great

jrattanpal commented 4 years ago

@dschach

I am changing base to another branch. I noticed some very minor thing which need to be fixed. I will fix those in a cleanup branch (after pulling your changes) And then merge to master.

Are you ok with it?

dschach commented 4 years ago

Sounds good. I'm curious what needs to be changed, but happy to take a look at your other branch once it's ready to merge back to master.

jrattanpal commented 4 years ago

Sounds good. I'm curious what needs to be changed, but happy to take a look at your other branch once it's ready to merge back to master.

I'll let you know once I submit the changes. There were minor things but It maybe that I am not doing the resolve correctly.

for example:

reports/FOLDER.XML file was missing
I received error that "viewSurveyResultsComponentController.cls" name didn't match with class name. Class name started with Capital V. I have never seen this error before but renaming the file to capital V worked. I am not sure why it worked for you but not me. Strange.

jrattanpal commented 4 years ago

These are the minor changes I had to make becuase of filename and class name mismatch. Not sure If those were caught because I am on Mac. I was finally able to push this in a scratch org.

https://github.com/SalesforceLabs/survey-force/commit/d6e0c5737b066546f9c05a78ed66bedc1f4689dd

jrattanpal commented 4 years ago

It seems you may not have pulled all changes from master where I renamed some classes this morning. That is causing conflicts. I will need to manually resolve those. It will take some time

jrattanpal commented 4 years ago

@dschach

All your changes are in master. I had to do it from command line because of conflicts. Please check the master branch to make sure all is good. You can run orgInit to create new org (if you want) and test.

please let me know.

I will close this pull request as it's no longer need.

THANK YOU again for this. This is VERY HELPFUL!