SalieriC / SUCC

SWADE Ultimate Condition Changer
GNU General Public License v3.0
7 stars 7 forks source link

[Bug] Effects without element img and name #96

Closed mrcomac closed 1 month ago

mrcomac commented 1 month ago

Describe the bug Hi folks,

I was testing the token HUD for SWADE due to this issue. The reason for the issue is that when enabled, the SUCC module uses icon instead of img and label instead of name. I didn't investigate deeply to see if it's creating new entities or if it is required for some reason, but is it possible to keep it compatible with the current SWADE system? I think those are old elements, and the system currently uses new ones.

To Reproduce Steps to reproduce the behavior:

  1. Enable the token HUD
  2. Enable the SUCC

Expected behavior Keep compatibility to the swade system.

Screenshots there is a image in the original issue

Desktop (please complete the following information):

Additional context N/A

jasharen commented 1 month ago

Same issue here, and essentially the same version information.

ddbrown30 commented 1 month ago

This is a bug in the Token Action HUD swade module. Caused by this commit: https://github.com/mrcomac/token-action-hud-swade/commit/e4c46f6cbb8f3736dc66b9a53b2ff04baf791382

I've replied on the original issue.

ddbrown30 commented 1 month ago

If you grab version 1.1.0 of token-action-hud-swade, it will fix the issue for you.

https://github.com/mrcomac/token-action-hud-swade/releases/tag/1.1.0

ddbrown30 commented 1 month ago

Never mind. I was doing something dumb. I'll fix it.