search

SalieriC / SWADE-Spices-Flavours

A theme editor for the SWADE System on Foundry VTT.
GNU General Public License v3.0
4 stars 3 forks source link

Feature Request: better visual for active effect on/off toggle #8

Closed Alis-72 closed 3 years ago

Alis-72 commented 3 years ago

Love your work! Small feature request: current toggle for active effects in character sheet is visually a bit vague, difference with 'on' or 'off' state is too small to see quickly (for us with old eyes). It would be awesome if that could be made visually more prominent. Maybe slider button or play/pause icons?

SalieriC commented 3 years ago

I like the idea. I was thinking about something like this: image And before you ask: Yes, I was thinking of colouring the off red but I don't know how to do that yet, I need to do more research on if and how it is possible. Changing the button itself seems difficult I have no idea how I would do that at all. The solution with the colour however is easy when I force it on the user. An optional solution ultimately comes down to learning css variables first and thus is tied to #5. When I can get the hang of it, I should be able to do it. Anyhow, what do you think of colorising it the way in the screenshot @Alis-72, would that be alright for you?

Alis-72 commented 3 years ago

Coloring works great for me. Not so great for color-blind persons, though accessibility might be something for different module.

SalieriC commented 3 years ago

Good point. That would be something for Foundry itself I suppose. Maybe create an issue for changing the image of it on Foundrys GitLab?: https://gitlab.com/foundrynet/foundryvtt I think accessability should be something on everyones concern right now but I think it is better suited for the core software.

Alis-72 commented 3 years ago

I'll create new ticket there. This ticket just became obsolete.

SalieriC commented 3 years ago

Closed by accident. Will still try to figure out a way to colorise it, as I think it'd be super cool. ^^

SalieriC commented 3 years ago

Okay, done. It's not optional atm but will hopefully be once I figure out how CSS variables work. Will keep this issue open for the time being. image

SalieriC commented 3 years ago

@javierriveracastro came up with an additional idea that hopefully also works for colourblind people. What do you think @Alis-72? image

SalieriC commented 3 years ago

@all-contributors please add @Alis-72 for a11y (accessibility issues) and ideas.

allcontributors[bot] commented 3 years ago

@SalieriC

I've put up a pull request to add @Alis-72! :tada:

SalieriC commented 3 years ago

@all-contributors please add @Alis-72 for a11y (accessibility issues) and ideas.

allcontributors[bot] commented 3 years ago

@SalieriC

I've put up a pull request to add @Alis-72! :tada: