search

SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)
GNU General Public License v3.0
10 stars 12 forks source link

[BUG] Mighty Summoner ‘Dismiss’ dialog not working #114

Closed Gallumph closed 1 year ago

Gallumph commented 1 year ago

I summon a creature, works like normal. But then I select the creature and get the full "Summon New" dialog instead of the "Dismiss This Creature" Dialog. Deleting the Active Effect manually dismisses the summon like normal. Versions: SWADE 2.2.2, SWIM 1.2.3

To Reproduce

  1. Select Summoner Token
  2. Use Mighty Summoner Macro
  3. Select any summon option, place Summon on the map (all working normally)
  4. Select the Summoned Token
  5. Use the Mighty Summoner Macro
  6. The full ‘Summon New’ dialog appears instead of the usual ‘Dismiss Thus Summons’ one.

A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

modules1 modules2

SalieriC commented 1 year ago

It might be connected to warpgate update that changed their flags. Note to self: Finally update the summoner script with SWIM flags to prevent this from happening in the future.

SalieriC commented 1 year ago

This is done now. Dismiss dialogue will be shown again and I moved over to using my own flags so this should be more resilient to changes in warpgate now. It won't work on already summoned tokens though, not sure how sensible it would be to create a migration for this. Probably would be a work of an hour or more and due to the short-lived nature of summoned creatures I think this isn't needed. Let me know if you think otherwise and I can create a macro for you that migrates already created tokens individually.