SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)
GNU General Public License v3.0
10 stars 12 forks source link

[NEW POWER] Modify Boost/Lower trait to support more functionality #118

Closed bloy closed 7 months ago

bloy commented 1 year ago

Power Boost/Lower trait builder enhancements:

detail:

Modifiers

Setting Savage Pathfinder & SWADE Fantasy Companion

SalieriC commented 1 year ago

Thank you for your time. This requires some work on the API of SUCC first and that is currently in the process of being rewritten. So don't expect it anytime soon.

bloy commented 1 year ago

if you don't mind pull requests, I was considering trying to hack at it a little bit this weekend, but if you have a big rewrite in mind I don't want to get in the way of that.

SalieriC commented 1 year ago

I don't mind you saving me time at all. :D Feel free to take a look at SWIM but SUCC is currently undergoing major changes and it is thus unlikely any PRs to the current module will make it into the new version. The problem with this feature is that I did not think about changing all properties of an AE when the data is passed to the SUCC API. Thus the label of an AE can currently not be changed using the SUCC API. This would've been a thing of a few minutes but the rework has to take priority ofc.

An alternative would be to get the effect after creation and then simply update it in SWIM but that's hacky and enhancing the SUCC API seems to be the better solution.

SalieriC commented 7 months ago

Closed due to inactivity. Feel free to reopen if you come up with a good solution.