search

SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)
GNU General Public License v3.0
10 stars 12 forks source link

Move Raise Calculator button (#121) #122

Closed mclemente closed 1 year ago

mclemente commented 1 year ago

Unrelated to the changes: Added a .prettierrc file since there were no formatting guidelines

SalieriC commented 1 year ago

That's a lot of lines changed for a single ticket. :D Thank you for your work. But please set the default for the raise calculator button to true. I understand that you don't like it but I do and I consider it a feature. Also is there a way to place it where it was before? As of now it's added to the bottom of the token controls row. If at all possible I'd like it to be where it was so that people who use it can find it where it was. If you get a chance to look into that I'll include it in the next release this weekend.

I'm also on the fence about all these other structural changes. Surely that's removing some of the chaos but I knew my chaos pretty well. ^^ But I'll decide that later, so no need to change it here.

SalieriC commented 1 year ago

On second thought: Could you please make a separate PR? One with just the button and then one with all the reformatting you've done? That would be much easier for me to review and thus easier to implement in a timely manner.