search

SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)
GNU General Public License v3.0
10 stars 12 forks source link

[BUG] The extend dialog for the Mighty Summoner has "undefined" #127

Closed steveculshaw closed 1 year ago

steveculshaw commented 1 year ago

Describe the bug After casting the Summon Animal power using the Mighty Summoner macro, the dialog for resetting the duration is showing "Remove undefined from character" ...

image

To Reproduce Steps to reproduce the behaviour:

  1. Summon Animal with duration 5 rounds
  2. Click through 6 rounds
  3. Dialog for extending power duration appears
  4. See "undefined" error

Expected behaviour The "undefined" to refer to something, not sure what? ... the name of the Power?

Desktop (please complete the following information): OS: [Windows 11] SWIM: [1.5.0] SUCC: [2.0.0] Swade System: [3.0.4] Foundry VTT: [11.302] Browser: [Google Chrome 114.0.5735.134] Other modules: BR2

Additional context N/A

SalieriC commented 1 year ago

I'll look into it, thanks. =)

SalieriC commented 1 year ago

I can reproduce it but I have no clue what's wrong. Gotta need help with that. It might also be a bug in the SWADE system so if you're able to reproduce it elsewhere please let me know.

steveculshaw commented 1 year ago

Will see if I can repo it 👍

SalieriC commented 1 year ago

Turned out to be a bug in SWADE. I've created a PR that aims to fix this issue: https://gitlab.com/peginc/swade/-/merge_requests/386

steveculshaw commented 1 year ago

Nice one

And thanks for resolving