search

SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)
GNU General Public License v3.0
10 stars 12 forks source link

Stepping away from AudioHelper due to upcoming API changes. #140

Open SalieriC opened 10 months ago

SalieriC commented 10 months ago

V12 has announced API changes that will severely impact SWIMs use of AudioHelper to play sound effects. The migration time lasts until v14 so there is plenty of time but getting ahead of it may be worth it just for the peace of mind. Alternatives are to use the higher concepts of playing audio (i.e. playlists or ambient sounds, not really suitable) or using sequencer. The latter would mean another dependency which is a problem but sequencer is not affected and proved to be in very active development. And some macros already use it for playing vfx anyway. Other than that just waiting and using the new methods of v12+ is also a possibility.

SalieriC commented 10 months ago

A good first step would be a general cleanup of the code so that swim.play_sfx() is used across the board instead of using AudioHelper scattered around the module. This would mean the breaking change in core could be covered in just one place, instead of scattered around the module.

SalieriC commented 10 months ago

The more thought I give it the likelier Sequencer becomes. It's very flexible, perhaps too flexible but will offer a whole lot of options later on. On the other hand, should Sequencer fall out of development, it will result in a massive loss of functionality. But I think that Sequencer is so established and such a staple in the community that it will very likely be adopted by s/o should Wasp ever decide to abandon it. And that currently seems unlikely anyway.