SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)
GNU General Public License v3.0
10 stars 12 forks source link

[BUG] Character sheets from the Shape Changer macro not deleting correctly #152

Open nathou54545 opened 2 months ago

nathou54545 commented 2 months ago

Describe the bug If i use the Shape Changer macro on the same token two times in a row without reverting to the original form, the first character sheet created by the macro will not be deleted

To Reproduce Steps to reproduce the behavior:

  1. Set up the macro correctly,
  2. Select a token, then execute the Shape Changer macro
  3. Choose a target form (exemple : cat) and click on the Shape Change button
  4. Execute the macro on the same token again
  5. Choose another target form (exemple : dog) and click on the Shape Change button
  6. Execute the macro again, but this time click on the Revert Form button
  7. Inside the "SWIM Chape Changing" folder, the first character sheet created by the macro should still be here (the cat form)

Expected behavior Instead, both characters sheets should have been deleted

Screenshots Before shape change image After the first shape change image After the second shape change image After reverting image

Desktop (please complete the following information):

Additional context Haven't reproduced the bug without unnecessary modules

SalieriC commented 15 hours ago

Wow, that is a perfect report, thanks. =) I'll take a look at it. The code needs to be changed quite a bit anyway in order to deprecate the warpgate functions.