[FEATURE] Bring back shape changer token merging

SalieriC / SWIM

A collection of macros for the SWADE system on Foundry with a focus on immersion (i.e. by using sound effects)

GNU General Public License v3.0

10 stars 12 forks source link

[FEATURE] Bring back shape changer token merging #94

Closed SalieriC closed 1 year ago

SalieriC commented 2 years ago

The Shape Changer has a lot of problems with the merging/blending functionality introduced by @pmoore603. Could you please check that in the v10 branch and make the necessary adjustments? Otherwise I'll have to deprecate this feature as I lack the time to fix it myself, sorry. The errors continue to come up as long as the blending happens it seems.

SalieriC commented 2 years ago

The following lines were commented to prevent the issue until further investigation: https://github.com/SalieriC/SWADE-Immersive-Macros/blob/459a226184c8c559c260d82aec3047788ff87059/swim/scripts/swim_modules/shape_changer.js#L245 https://github.com/SalieriC/SWADE-Immersive-Macros/blob/459a226184c8c559c260d82aec3047788ff87059/swim/scripts/swim_modules/shape_changer.js#L360 https://github.com/SalieriC/SWADE-Immersive-Macros/blob/459a226184c8c559c260d82aec3047788ff87059/swim/scripts/swim_modules/shape_changer.js#L375

It's likely that the feature will be disabled in the upcoming version.