Salinn / phitau

A rails application for the Gamma Nu chapter of Phi Kappa Tau's website
http://gammanu.org/
1 stars 0 forks source link

Header wrap fix #2

Closed dmccabe closed 9 years ago

dmccabe commented 9 years ago

@Salinn Please review. In order for the overrides to work properly with bootstrap-sass, the values have to be defined before you import bootstrap. That's because of the way it initializes - it uses SASS !default, which means that it will normally set its own value, but won't do that if the value already exists. If you don't define it before the import though, it'll get used by bootstrap-sass before you ever change the value, so it won't work. So the key here is you just need to make sure the order of execution is well defined.

I had trouble getting the gems installed on my machine for some reason, so I haven't actually been able to verify this works correctly. You should definitely give the branch a test drive before merging. Also, I removed the other screen mins you had setup under the assumption you had just been playing with them trying to get this to work - feel free to put those back in place if you actually need them.