SalishSeaCast / SalishSeaNowcast

Python package associated with running the SalishSeaCast NEMO and other ocean models in near-real-time to produce daily nowcasts/forecasts
https://salishsea.eos.ubc.ca/nemo/
Apache License 2.0
4 stars 3 forks source link

Fix broken web site time series plots. #249

Closed douglatornell closed 3 months ago

douglatornell commented 3 months ago

Web site time series plots broke when v202111 was released because the ERDDAP URLs that they use to access the model results were not updated.

Also improve make_plots worker unit tests:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.79%. Comparing base (2bdd7ca) to head (dbdb26b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #249 +/- ## ========================================== + Coverage 77.73% 77.79% +0.06% ========================================== Files 133 133 Lines 18769 18817 +48 Branches 1906 1910 +4 ========================================== + Hits 14590 14639 +49 + Misses 4112 4111 -1 Partials 67 67 ``` | [Flag](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/249/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | `77.79% <100.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.