SalishSeaCast / SalishSeaNowcast

Python package associated with running the SalishSeaCast NEMO and other ocean models in near-real-time to produce daily nowcasts/forecasts
https://salishsea.eos.ubc.ca/nemo/
Apache License 2.0
4 stars 3 forks source link

Update make_live_ocean_files re: single filepath #269

Closed douglatornell closed 1 month ago

douglatornell commented 1 month ago

salishsea_tools.LiveOcean_BCs.create_LiveOcean_TS_BCs() returns a single filepath not a list of filepaths. As a result of this change, the related logging message and checklist assignment have been updated and corresponding test cases have been adjusted as well.

Also update make_live_ocean_files worker main() function docstring to remove not informative "Set up and run the worker." line at the beginning.

re: issue #121

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.63%. Comparing base (af1ebab) to head (600f13d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #269 +/- ## ======================================= Coverage 77.63% 77.63% ======================================= Files 133 133 Lines 18686 18686 Branches 1910 1910 ======================================= Hits 14506 14506 Misses 4113 4113 Partials 67 67 ``` | [Flag](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/269/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/269/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | `77.63% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.