SalishSeaCast / SalishSeaNowcast

Python package associated with running the SalishSeaCast NEMO and other ocean models in near-real-time to produce daily nowcasts/forecasts
https://salishsea.eos.ubc.ca/nemo/
Apache License 2.0
4 stars 3 forks source link

Pin cfgrib package at version 0.9.11.0 #276

Closed douglatornell closed 2 weeks ago

douglatornell commented 2 weeks ago

cfgrib 0.9.12.0 introduced support for ecCodes 2.34.0 feature of GRIB files with sub-hourly steps. That appears to result in incorrect values for the valid_time variable in the GRIB files produced by the crop_gribs worker. This version pin prevents that problem until we can get an upstream resolution.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.64%. Comparing base (81e4d25) to head (22d7918). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ======================================= Coverage 77.64% 77.64% ======================================= Files 133 133 Lines 18698 18698 Branches 1911 1911 ======================================= Hits 14518 14518 Misses 4113 4113 Partials 67 67 ``` | [Flag](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/276/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | `77.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.