SalishSeaCast / SalishSeaNowcast

Python package associated with running the SalishSeaCast NEMO and other ocean models in near-real-time to produce daily nowcasts/forecasts
https://salishsea.eos.ubc.ca/nemo/
Apache License 2.0
4 stars 3 forks source link

Replace warning suppression in crop_gribs worker #277

Closed douglatornell closed 3 months ago

douglatornell commented 3 months ago

The 'warnings' module import and its associated catch-block have been removed from crop_gribs.py. Instead, a 'no_warn' argument has been added directly to the 'to_grib()' function call. This results in a cleaner, more efficient, and more direct way to suppress warnings within the specific context.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (1dc149f) to head (22281f1). Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
nowcast/workers/crop_gribs.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #277 +/- ## ======================================= Coverage 77.64% 77.65% ======================================= Files 133 133 Lines 18698 18695 -3 Branches 1911 1910 -1 ======================================= - Hits 14518 14517 -1 + Misses 4113 4111 -2 Partials 67 67 ``` | [Flag](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/277/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | `77.65% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.