SalishSeaCast / SalishSeaNowcast

Python package associated with running the SalishSeaCast NEMO and other ocean models in near-real-time to produce daily nowcasts/forecasts
https://salishsea.eos.ubc.ca/nemo/
Apache License 2.0
4 stars 3 forks source link

Update datetime format in VFPA HADCP observation handling #282

Closed douglatornell closed 1 month ago

douglatornell commented 1 month ago

The datetime parsing format was adjusted in the VFPA HADCP sensor observation handling module. This change will ensure the timestamp is correctly interpreted as YYYY-MM-DD HH:MM as opposed to the previous format DD/MM/YYYY HH:MM. This change was necessitated by a change in the datetime format in the observation .csv files that was made between 17:00 and 18:00 UTC on 2023-07-02.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (66db22d) to head (2d149fd).

Files Patch % Lines
nowcast/workers/get_vfpa_hadcp.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #282 +/- ## ======================================= Coverage 77.65% 77.65% ======================================= Files 133 133 Lines 18695 18695 Branches 1910 1910 ======================================= Hits 14517 14517 Misses 4111 4111 Partials 67 67 ``` | [Flag](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/282/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/SalishSeaCast/SalishSeaNowcast/pull/282/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast) | `77.65% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SalishSeaCast#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

douglatornell commented 1 month ago

Successfully used in bash loops in production environment to backfill 3-Jul-2023 to 12-Jul-2024 obs csv files into netCDF dataset.