search

SalmonDE / SkinChanger

A badly written experiment with skins and capes on mcpe servers
GNU General Public License v3.0
15 stars 5 forks source link

Please Rewrite it! @SalmonDE #15

Closed SalmonDE closed 6 years ago

SalmonDE commented 7 years ago

Note to myself. I hope I won't forget it.

Aericio commented 7 years ago

@SalmonDE plz rewrite

SalmonDE commented 7 years ago

@aericio how funny. I totally forgot this

ghost commented 7 years ago

code cleanup or optimization ?

SalmonDE commented 7 years ago

@KairusDarkSeeker As soon as I start I'd probably try to do both

ghost commented 7 years ago

@SalmonDE okay

Aericio commented 7 years ago

@SalmonDE please, make skinchanger great again with a rewrite!

Aericio commented 7 years ago

also, i want an api.

SalmonDE commented 7 years ago

@Aericio You want an API for other plugins I suppose, but what should it offer?

Aericio commented 7 years ago

@SalmonDE changing their skin, removing their skin, getting their skin id.

SalmonDE commented 7 years ago

Player->setSkinData(), Player->getSkinData(), Player->setSkinId(), Player->getSkinId()

It makes no sense to add an alias for these ones in SkinChanger. However getting the skins of saved ones could be added.

Aericio commented 6 years ago

@SalmonDE lazy lazy