Great idea, really bad code

SalmonDE / SkinChanger

A badly written experiment with skins and capes on mcpe servers

GNU General Public License v3.0

15 stars 5 forks source link

Closed legoboy0215 closed 7 years ago

legoboy0215 commented 7 years ago

Bad as in very badly optimized. Seriously, you are lagging the shit out of a server I work for. Can you at least try and optimized?

SalmonDE commented 7 years ago

Actually I guess there is a thing I could change.

Edit:

Done. I forgot to delete the player skins when they quit. Also you can completly disable the temporary saving now.

legoboy0215 commented 7 years ago

Also, str_ireplace is like useless. Better change that to str_replace.

SalmonDE commented 7 years ago

@legoboy0215 Well that makes message lines case sensitive, but it shouldn't make much difference so I'm fine with that