search

SalmonSays / SlamminSalmonsMinesRecrafted

0 stars 0 forks source link

[Meta] config folder contains config files for mods not installed in the pack #15

Open nooshstuff opened 5 years ago

nooshstuff commented 5 years ago

I assume those were mods that were tested and removed. Examples are:

gravitygun.cfg

portalgun.cfg

computercraft.cfg

If you want I can look through them and mark the ones that don't seem to have an associated mod.

This issue is only relevant to people who want to contribute to make the configs clearer and easier to navigate, this could somehow be an issue for the modpack itself but I doubt it.

SalmonSays commented 5 years ago

I can guarantee it'll never be an issue for the modpack, but some of the mod configs are probably remnants going all the way back to 1.6.4 so it couldn't hurt to prune stuff that we'll definitely never use again.

nooshstuff commented 5 years ago

Do you want help with the pruning?

SalmonSays commented 5 years ago

I can't promise a definite timeline for it given how little of an impact it'll actually have on the gameplay, but if you feel like working on it feel free to get started- once a pull request is sent it'll be really quick for me to glance at and approve changes!

nooshstuff commented 5 years ago

Alright I'll set some time to compare the mods list to the configs list and make a list of A. ones we definately don't have use for and B. ones that I'm unsure which mod it belongs to/if we need it or not

SalmonSays commented 5 years ago

I had a change of heart and figured I'd do a quick sweep for things that jumped out at me, you should have a much easier time now

SalmonSays commented 5 years ago

One of these days I'll have to do a diffcheck on server-configs and see if I can merge the two together. Sometimes it's for practical reasons, like not wanting to have my discord bot private keys shared, but other times it's because I can get away with a server-only config change and feel too lazy to push those changes back to clients for singleplayer use.

nooshstuff commented 5 years ago

image LINK TO SHEETS (with comment permissions)