Saltarelle / SaltarelleCompiler

C# to JavaScript compiler – Now http://bridge.net
http://saltarelle-compiler.com
Other
297 stars 74 forks source link

INTERNAL ERROR: ResolveResult ConversionResolveResult #435

Open n9 opened 9 years ago

n9 commented 9 years ago

In develop, I am getting INTERNAL ERROR: ResolveResult [ConversionResolveResult System.Func1[[System.Threading.Tasks.Task1[[System.Int32]]]]] is an error. with this code:

            Func<Task<int>> f = async () =>
            {
                throw new Exception("Foo");
            };

Not sure whether it is already fixed on Roslyn/Bridge.Net 2.

erik-kallen commented 9 years ago

Probably an NRefactory bug

michaelcheers commented 7 years ago

@n9, @erik-kallen, it is not an NRefactory bug as it works in Bridge.NET.

n9 commented 7 years ago

@michaelcheers The current Bridge.NET is using the same NRefactory as Salterelle in 2015?

geoffreymcgill commented 7 years ago

https://www.nuget.org/packages/Bridge.NRefactory https://github.com/bridgedotnet/NRefactory

Includes several NRefactory bug fixes.

https://dev.deck.net/85d5a66bf8dc279df25567ed7473a44f

public class Program
{
    public static void Main()
    {
        Func<Task<int>> f = async () =>
        {
            throw new Exception("Foo");
        };
    }
}
n9 commented 7 years ago

@michaelcheers

If something works in current Bridge.NET and not in Saltarelle, it does not mean that it could not be caused by an NRefactory bug. Saltarelle was acquired by Object.NET, however Object.NET let it die. It is no longer developed, dependencies are not updated. (For more information, please read https://github.com/Saltarelle/SaltarelleCompiler/issues/430.)

I am not sure why are you commenting old bugs in Saltarelle. If the reason is that you are searching for alternative to Bridge.NET, I would suggest you to learn F# and try http://fable.io/.

In case you are going to migrate a larger code base from Saltarelle to Bridge.NET. I would suggest you to wait until all portarelle issues are resolved. Otherwise, you might get crazy after several days of migration that thinks works differently in Bridge.NET. (I do not know ETA of all portarelle issues to be cleared.)

geoffreymcgill commented 7 years ago

Hi @n9 – The outstanding 40 portarelle issues haven't been reviewed in a while, but we were just talking about this task in our team meeting. We'll try out best to review and update the issues again soon. With a quick scan, there are certainly several portarelle issues that are now supported and can be closed.

Most of the items on that list, and any other Saltarelle features missing from Bridge, will only be dealt with if the community requests.

Be sure to review the Upgrade from Saltarelle wiki document if you're moving from Saltarelle to Bridge.