SaltyAom / hifumin

Opensource optimized Hentai Platform
https://hifumin.app
117 stars 11 forks source link

Refactor: Initial restructure #2

Closed SaltyAom closed 3 years ago

SaltyAom commented 3 years ago

Next.js together with Tailwind doesn't play well with Stylus. Furthermore, Next deprecated usage of @zeit/next-stylus which is why I decided to move from Stylus to Sass.

However, moving from old structure required a lot of changed including moving from deprecated tslint, from Mocha and Enzyme to React Testing Library, withPreact plugins and most importantly TypeScript strict mode which made it hard for migration.

This PR introduced all initial migration written above.

This migration will ensure more future proof for the dependencies has much better support. FBK

There still much room for improvement for migration, for example re-structuring project's structure, re-written CSS as atomic scale and more but this is like an initial migration for that.

Note: We moved to Tailwind 2, however due to Next plugins itself doesn't work with PostCSS 8 yet, we're using Tailwind Compatibility build and PostCSS 7 which will be migrated to PostCSS 8 as soon as Next plugin support PostCSS 8.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/aomkirby123/opener-studio/n9pr981yo
✅ Preview: https://opener-studio-git-feat-restructure.aomkirby123.vercel.app

SaltyAom commented 3 years ago

Looking good! Let's merge it right away~

Happy fox