SalvadorCali / Adrenalina

2 stars 0 forks source link

Class position in UML #2

Closed michele-bertoni closed 5 years ago

michele-bertoni commented 5 years ago

Good morning, I saw your UML and it's very good. The only thing I don't like is class Position, which is attached to Player, but nothing else. How can you understand which square the player is inside, if there is no direct correlation between those classes?

SalvadorCali commented 5 years ago

We have a list of players in each square and we can also compare the player's position with the square's position in the gameboard.

Rule question: during the scoring phase is it correct if we don't give points to the players who don't make damage to the dead player?

ingconti commented 5 years ago

a side question: did You read carefully game rules? no explicit advice about?

SalvadorCali commented 5 years ago

Yes. In fact I've asked it to avoid any doubt and not to implement the game in a wrong way

ingconti commented 5 years ago

ok, the preferred place to ask about game (as we said.. ) is omg Piazza.

michele-bertoni commented 5 years ago

We have a list of players in each square and we can also compare the player's position with the square's position in the gameboard.

Then square must be attached also to Square. You told it... Fix, reupload and then I'll check end eventually close the issue.

pitt1095 commented 5 years ago

do you mean that the square class has an implicit reference to the Position class?

michele-bertoni commented 5 years ago

It's not implicit, it's an actual reference

SalvadorCali commented 5 years ago

So, do we have to add a link from Square to Position in the UML, or modify anything in the code? In the second case we didn't understand what we should do in the current situation

SalvadorCali commented 5 years ago

Sorry, have you got any answers?

michele-bertoni commented 5 years ago

In the UML you should add an arrow between Square and Position. Sorry for the delay in the answer, but I thought you already fixed the problem

SalvadorCali commented 5 years ago

Fixed

michele-bertoni commented 5 years ago

Fixed.