Closed michele-bertoni closed 5 years ago
I think everything it's ok. Fixed. It was a wrong import.
We're facing some problems building the jars. We tried to follow the info you gave in the last lab, including the maven-assembly-plugin and running mvn clean package, but only a non-runnable jar was created in the target folder. Can you give us any further advice?
In alternative: Is it possible to build the jars from the standard "Build Artifacts"? ....and in that case, which things we can remove to make them lighter?
I've always built jar from maven with this code and everything worked fine:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<archive>
<manifest>
<mainClass>
App
</mainClass>
</manifest>
</archive>
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
</configuration>
</execution>
</executions>
</plugin>
Ok, I managed to build the server.jar and the client.jar using maven-assembly and they run correctly. May I ask you what I have to exclude from the server and client jars to make them correct and lighter? Also, what's the best procedure to do it?
target ONE:
server.jar runs correctly on ANY other pc/Mac/linux AND client.jar runs correctly on ANY other pc/Mac/linux
don't mind in this phase to get a "light" binary. as noted on Piazza, we do NOT make reverse engineering to verify you added too much stuff.
so reach target... it's mandatory and time is short.
ok, we already tested that client and server from jars are working on pc/Mac/linux with both socket and rmi.
NICE! you are done!
Anyway, we were asking how to make light jars because I saw that the upload limit on git is 25Mb, and our jars are 30Mb. The weight is mainly given by graphic png components, so the server jar isn't a problem. But is there anything we can do to make the client.jar uploadable without splitting it?
did You try to reduce PNGs a bit in photoshop? Are sizes already correctly Or you scale pngs down?
now the project's size is almost 16Mb
good job! so prepare a nice presentation you and your colleagues: everything should work like a breeze.
(ps "presentation" in the sense of a "pro" demo, not a PPT :) )
I close this "not-a-real-issue". If you need more help, just reopen it. By the way, good job! MB
Will be GUI completed for tomorrow? When you're done, please update the readme. I hope everything's ok, because without the GUI your grade would decrease significantly: you worked very well during the whole year and we would like to assign you the grade you deserve.
the gui is completed we'll update the readme tomorrow morning!
I fixed it, now also the readme is ok
Perfect, see you on monday!
Hi, just wanted to know how is it going. I saw you decided to do only one advanced functionality. From yesterday evening your code is not compiling anymore:
[ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /var/jenkins_home/workspace/AM03/src/main/java/it/polimi/ingsw/util/Parser.java:[3,42] package com.sun.org.apache.regexp.internal does not exist
probably there is a problem with the pom.xml You worked very well during the year, so I just wanted to know if everything's ok. If you have any questions, just ask us.
MB