search

Sam-Dunlap / Draft-Boy-Advance

Other
1 stars 1 forks source link

**Minor Issue** - Draftee can be added more than once to the draft #3

Open MarkCapka opened 3 months ago

MarkCapka commented 3 months ago

Location: DraftBoyAdvance/commands/addtodraft.js

Issue: When using the 'add to draft' command from within discord, there is no warning or error thrown when a user is added as a duplicate.

Impact: if gone unnoticed it could cause an issue with duplicate entries of a user into the draft

Fix: when 'Add To Draft' command is run -Check if the user being added to the draft already exists -if exists: return error message: 'cannot add to draft as they are already signed up!' - no alteration to Pick order -else: - standard add to draft process.

MarkCapka commented 3 months ago

NOTE -- maybe this is intentional? --use case: for sake of testability of multiple users in the draft from a lone developer in a server?

image