Sam-Max / plugin.video.jacktook

A Kodi addon for torrent finding and streaming
GNU General Public License v3.0
50 stars 9 forks source link

Kodi Matrix compatibility #30

Closed addon-rajada closed 7 months ago

addon-rajada commented 7 months ago

As the VideoInfoTag is something new (Kodi 20+), it would be possible to keep compatibility with Kodi 19? Currently in Kodi 19 none movie/tvshow ListItem shows up

Sam-Max commented 7 months ago

Maybe drop compatibility for kodi 19 would be a good idea. Do you use kodi 19? If so why not use kodi 20?

addon-rajada commented 7 months ago

Yeah, i still using it at some devices (lightest I.M.O.), so this compatibility would be great. I personally think they killed Kodi Matrix too fast. It's still indeed python 3. I guess just avoid use VideoInfoTag (if version 19) would be enough to make the addon work.

Sam-Max commented 7 months ago

Yes, adding a conditional to check kodi version, and if version is less than 20 not to use VideoInfoTag

addon-rajada commented 7 months ago

At first i got the error Failed to convert to input type to either a std::string or a std::vector. But now, last commit version is working flawlessly.

Closing the issue