search

SamAmco / track-and-graph

An android app for tracking personal data and creating custom graphs
GNU General Public License v3.0
438 stars 40 forks source link

Allow to set Monday as the first day of the week #155

Open steel-steven-87 opened 2 years ago

steel-steven-87 commented 2 years ago

Please add an option to set Monday as the first day of the week.

According to [1], Monday is considered to be the first day of the week according to ISO 8601 standard. Furthermore, this is also used in around half of the countries in the world, see the world map in [2].

I find your app really useful, but having Sunday as the first day of the week is confusing. I believe this enhancement would make your app more enjoyable to use and make it more welcoming to the users from other countries.

References: [1] https://www.timeanddate.com/calendar/days/ [2] https://commons.wikimedia.org/wiki/File:First_Day_of_Week_World_Map.svg

SamAmco commented 2 years ago

Hi. Thanks for the feedback. A few people have asked for control over when the day starts and when the week starts. Definitely something I want to put in at some point. Out of interest where are you seeing Sunday as the first day of the week? How does this affect you. I think this is driven by locale currently everywhere in the app. I am in the UK so my device regards Monday as the first day of the week.

steel-steven-87 commented 2 years ago

The feature that gets affected is the graph where you can see the weekly accumulation of the tracked items.

Since you mentioned that you saw Monday as the first day of the week on your device, I started looking into this and I found out the locale on my device was set to English (US), but I can't remember ever configuring this. When I set it to English (UK), the weekly counter started showing the stats for Monday-Sunday as expected.

Adding instructions in case anyone else needs to make the same adjustment:

  1. Go to Settings > System > Languages and input > Languages.
  2. Add "English (UK)" and move it up, so it appears as the first language.
  3. Force stop Track & Graph and reopen it or just restart the device.

@SamAmco Thanks for pointing out that the app uses the setting of the default locale. This solved the issue.

SamAmco commented 2 years ago

Glad you managed to find a fix. I think people will want more granular control at some point so i will leave this ticket open until I implement controls in app for this.