search

SamAmco / track-and-graph

An android app for tracking personal data and creating custom graphs
GNU General Public License v3.0
438 stars 40 forks source link

New forms #261

Closed PropellantDyke closed 9 months ago

PropellantDyke commented 9 months ago

Switches feels more "modern" for boolean fields. Consistency in other forms can be done later using the new UI component RowSwitch.

Related to #256

SamAmco commented 9 months ago

Two thoughts on this.

  1. I think there's only one other reference to row checkbox in the whole project. I think you might as well change all of them.
  2. I think it would be a little more consistent if it was orange rather than blue?
SamAmco commented 9 months ago

Another thing to mention here is that as you update UI the screenshots go out of date. That's both the app screenshots which live under fastlane/metadata/android/en-GB/images/phoneScreenshots and also the faq screenshots and gifs which live under docs/faq/images.

Until now it's been near impossible for anyone to update these because the data is not available to them, and even if it was the data needs to be up to date for some of the graphs to look right, so it needs to be generated rather than static.

I managed to find time the last couple of days to write some code that generates a database full of demo data. See base/src/androidTest/java/com/samco/trackandgraph/DemoDBGenerator.kt. It is basically just an espresso test that you can run on your device/emulator which will generate and save a demo database file in the Documents directory of your device (typically this is the on device Documents directory not the external SD card one). You can then import this database in track and graph (or a debug build) and take screenshots/gifs of the data there.

It's not a huge issue for this PR, but I did this because I realised I wasn't comfortable releasing your recent UI changes to the tracker cards without first updating the screenshots and this has been a pain point for a while. It's still a bit of a process but it's a lot better than it was. At least now technically someone else can do it.

PropellantDyke commented 9 months ago

Oh thanks for the script! I will try to keep the screen shot up-do-date :) I agree with you too first points also.