SamB440 / Tale-of-Kingdoms

An adventure of glory in the world of Minecraft - Revival of Tale of Kingdoms mod
GNU General Public License v3.0
17 stars 3 forks source link

Switching worlds wipes Guild Quest progress #134

Open Obink1025 opened 2 years ago

Obink1025 commented 2 years ago

Summary

I installed this mod in a mod pack called All of Fabric 3 (AoF3) which is on the FTB App. It runs as usual for the most part, but I noticed a bug when switching between worlds.

If I start a guild quest (and the castle gets created) in, say, World 1, and switch to another world, say, World 2, I am prompted to start a new guild quest. This is normal, but if I do not start a new quest in World 2, and I switch back to World 1, my initial guild quest is gone and I am prompted to start a new quest in World 1. If I proceed with starting a new guild quest then a new kingdom will be created.

I do not know if this is a bug caused by mod conflicts, as I haven't seen any other issue reports on this, but I'm reporting because it caused me to lose my house and lots of hours of progress in my Minecraft world.

Steps to reproduce

Create a new world, World 1 Go into World 1, and begin a guild quest (which should cause the kingdom to be built) Exit World 1 Create a new world, World 2 Open World 2 and close the prompt to start a guild quest Exit World 2 Open World 1, and open your inventory (your number of Gold Coins is now reset) Press "k", The guild quest prompt should appear, allowing you to start a new quest.

Expected behaviour

Not starting a Guild Quest in World 2 would make it so that there isn't an existing quest in World 2 until the player presses "k" to bring up the prompt again.

Mod list

addendum-fabric-1.16.5-1.0.2.jar Adorn-1.14.2+1.16.5.jar advancements-enlarger-0.2.3.jar advdebug-2.3.0.jar AE2WTLib-1.2.6-release.jar alaskanativecraft-1.2.2.jar appleskin-fabric-mc1.16.5-2.3.0.jar appliedenergistics2-fabric-8.4.0-alpha.3.jar architectury-1.29.50.jar ArmorSoundTweak-3.1.1-fabric.jar artifacts-4.0.3+fabric.jar attribute-fix-fabric-1.0.2.jar authme-mc1.16.5-2.1.0.jar autoconfig1u-3.3.1.jar bambootweaks-2.0.5-fabric.jar battletowers-3.3.4-1.16.4.jar bclib-0.1.45.jar bedspreads-fabric-1.3.1-1.16.4.jar better-end-0.9.8.5-pre.jar BetterCaves-Fabric-1.16.5-1.2.jar BetterDungeons-Fabric-1.16.5-1.0.1.jar BetterMineshafts-Fabric-1.16.4-1.0.2.jar BetterStrongholds-Fabric-1.16.5-1.1.1.jar biome-makeover-1.16.5-1.3.8.jar biome_locator-1.1.2.jar bitsandchisels-2.3.2.jar blast-1.5.2.jar blockshifter-1.4.0+fabric-1.16.4.jar blockus-2.1.12+1.16.5.jar boringbackgrounds-3.0.2+1.16.3.jar breakprogress-1.0.1.jar builtin-servers-1.0-BETA.jar byg-1.1.8.jar campanion-1.3.5.jar can-i-mine-this-block-1.0.2.jar Cardinal-Components-API-2.8.3.jar carrier-1.7.6.jar cavebiomes-0.6.2.jar cc-restiched-1.96.3.jar charm-fabric-1.16.5-2.3.2.jar charmonium-fabric-1.16.5-2.3.2.jar cherishedworlds-fabric-2.0.1-1.16.5.jar chillager_mod-1.1.jar Chunky-1.2.54.jar cinderscapes-1.4.0.jar cleancut-mc1.16-2.1-fabric.jar cloth-api-1.6.59.jar cloth-config-4.13.49-fabric.jar colorfulcolumns-1.0.0.jar columns-1.1.1.jar compressedblocks-1.0.1.jar conjuring-0.2.5.jar Controlling-For-Fabric-1.1.3.jar Couplings-1.3.6.jar crookedcrooks-1.3.3+1.16.4.jar Croptopia-1.16.4-5-FABRIC-1.4.0.jar crusade-mod-1.2.1.jar dankstorage-1.9a-1.16.3.jar DarkPaintings-Fabric-1.16.5-3.0.4.jar dawn-1.8.jar decimalCoins-fabric-1.16.5-1.3.0.jar deepmoblearning-refabricated-0.3.3-beta1.jar DefaultSettings-1.16.x-3.0.2.jar diggusmaximus-1.4.2-1.16.3.jar DisableCustomWorldsAdvice-1.4.jar drinkbeer-v3.0.2 for 1.16.x.jar DungeonsModLite-1.16.5-1.0.14.jar dwarfcoal-1.16.2-1.0.0.jar ecotones-0.7.2.jar eggtab-2.1.0+1.16-fabric.jar EnchantmentDescriptions-Fabric-1.16.5-2.0.8.jar entity-banners-1.16.5-1.0-BETA.jar expandedstorage-7.3.7+1.16.5.jar extra-generators-1.0.3-BETA+1.16.jar ezpas-1.2.2-1.16.5.jar fabric-api-0.42.0+1.16.jar fabric-furnaces-1.3.3-1.16.4.jar fabric-language-kotlin-1.7.0+kotlin.1.6.0.jar fabric-language-scala-2.0.0+scala.3.0.2.jar fallflyinglib-2.0.4.jar fatxporbs-0.0.9+1.16.4.jar fermion-mc116-2.9.221.jar ferritecore-2.1.0-fabric.jar ffl-trinkets-compat-1.0.0.jar Flamingo-oh-oh-oh-1.0.4-MC1.16.3-fabric.jar Flonters-1.1.1+1.16.2.jar flora-doubling-1.3.0+1.16.4-fabric.jar flytre_lib-0.2.11.jar FpsReducer-fabric-1.24-mc1.16.5.jar ftb-chunks-fabric-1605.3.2-build.115.jar ftb-library-fabric-1605.3.4-build.90.jar ftb-quests-fabric-1605.3.6-build.76.jar ftb-teams-fabric-1605.2.3-build.40.jar gate-of-babylon-1.4.4-1.16.5.jar geckolib-fabric-1.16.5-3.0.67.jar get-off-my-lawn-1.16.5-1.3.4-beta.jar give-me-hats-1.16-1.5.1.jar glassdoor-1.5.0-1.16.jar glassential-fabric-1.16.4-1.1.5.jar go-fish-1.2.3-beta-1.16.5.jar goldenhoppers-1.0.2.jar golemsgalore-0.2.1+mc.1.16.5.jar hard-hat-steve-1.2.0.jar Harvest-fabric-1.16.1-1.2.12-26.jar HealthOverlay-1.16.5-4.0.1.jar ignis-fatuus-1.1.3.jar IKnowWhatImDoing-4.0.0-fabric.jar improved-stations-2.0.3.jar indrev-1.9.18-BETA.jar inmis-2.2.1-1.16.5.jar InventoryHUD-fabric-[1.16.2-1.16.5]-3.4.1.jar InventorySorter-1.7.9-1.16.jar iron-jetpacks-0.3.1.jar item-filters-fabric-1605.2.5-build.9.jar jmx-mc116-1.22.185.jar jumpoverfences-1.16-0.0.3.jar kibe-1.16.5-1.7-BETA.jar kubejs-fabric-1605.3.19-build.289.jar lapisreserve-1.0.7.jar lazydfu-0.1.2.jar Library-Of-Exile-1.16.5-1.0.15.jar lifts-1.16.5-1.1.1-BETA.jar light-overlay-5.8.1.jar lightstones-1.3.0.jar lithium-fabric-mc1.16.5-0.6.6.jar magitekmechs-fabric-MC1.16-1.0.4.jar megane-4.1.4.jar miners-horizon-1.6.2-1.16.5.jar mixintrace-1.0.0.jar Mo-Glass-1.5-MC1.16.5.jar mocolors-1.1.2.jar Modern-Industrialization-0.4.0-alpha.11.jar modmenu-1.16.22.jar morevillagers-FABRIC-1.16.5-1.4.1.jar mostructures-1.2.0-1.16.5.jar MouseTweaks-fabric-mc1.16.5-2.22.jar MysticalAgriculture-Refabricated-1.16.5-1.1.7.jar mythic-mounts-1.16.5-4.0.jar netherite-plus-mod-1.4.3-1.16.5-fabric.jar ninjaphenix-container-library-1.2.10+1.16.5.jar no-potion-offset-1.0.2.jar NoAngleBrackets-1.0.1.jar notes-1.16.2-1.0.4.jar nourish-1.3.2.jar okzoomer-4.0.1+1.16.2.jar packages-1.16.4-1.1.1.jar Patchouli-1.16.4-53-FABRIC.jar phosphor-fabric-mc1.16.2-0.8.0.jar platforms-[fabric]-1.16-1.0.1-.jar pling-1.3.0.jar promenade-2.0.jar quarry-reborn-1.16-0.5.4.jar quickshulker-1.1.14-1.16.jar ratsmischief-1.1.2.jar RebornCore-1.16-4.7.3+build.136.jar repurposed_structures-1.16.5-1.11.6-fabric.jar reroll-1.2.1-1.16.5.jar respawnablepets-1.16.5-2.jar rhino-fabric-1605.1.5-build.75.jar riverredux-0.1.6.jar RoughlyEnoughItems-5.12.385.jar rswires-4.10.2.jar Runelic-fabric-1.16.5-1.0.2.jar sandwichable-1.2-rc4+1.16.jar secretrooms-0.9.5+1.16.5.jar shetiphiancore-[fabric]-1.16-1.0.1-.jar shulkerboxtooltip-2.3.8+1.16.5.jar simpleteleporters-2.2.1.jar simplexterrain-0.7.2.jar slight-gui-modifications-1.7.1.jar slotlock-1.0.3-BETA.jar smootherbedrock-1.0.3.jar someforgepatchesported-1.0.0.jar staffofbuilding-1.2.6-1.16.5.jar stonecutter-tweaks-1.1.0-1.16.jar strawdummy-1.4.0.jar survivalisland-0.1.6.jar TacoCraft-1.5.2+mc.1.16.5.jar taleofkingdoms-1.0.1.jar TechReborn-1.16-3.8.4+build.236.jar terrarian-slimes-1.1-BETA+1.16.jar terrestria-2.2.0.jar The_Graveyard_1.1(FABRIC)_for_1.16.4-1.16.5.jar TIS-3D-MC1.16.5-Fabric-1.6.2.35.jar ToolStats-fabric-1.16.5-1.0.1.jar tooltipfix-1.0.2-1.16.jar trapexpansion-1.16.2-1.3.3.jar travelers-backpack-1.16.5-5.4.0.jar traverse-3.3.3.jar trinkets-2.6.7.jar true-secret-rooms-1.1.3.jar untitledduckmod-0.2.2-fabric.jar vanilla-hammers-3.0.3-1.16.5.jar vanillaexcavators-2.1.2-1.16.2.jar villager-hats-fabric-1.16.4-1.0.1.jar winged-1.16.5-2.1.4.jar wirelessnetworks-1.0.3.jar Wither-Totems-Mod-0.3.2-1.16.2.jar wolves-with-armor-1.5.4-1.16.5.jar woodenhoppers-1.0.0.jar WoodsAndMires-1.0.4+1.16.3.jar wraith-croptosis-1.1.0.jar wraith-harvestscythes-2.0.4.jar wraith-waystones-2.0.2-1.16.5.jar wthit-2.10.11-fabric.jar xlpackets-1.1.jar yosbr-0.1.1.jar youre-in-grave-danger-1.0.3.jar YungsApi-1.16.5-Fabric-9.jar [1.16.4] MoreTooltips-1.0.1.jar

Possible fixes

Each Guild Quest should be exclusive to it's own world, meaning multiple Guild Quests should be able to be active at the same time, in different worlds. Each world should have it's own separate Guild Quest, rather than only one Guild Quest able to be active at a time.

Relevent logs and/or screenshots/videos

No response

Other

No response

SamB440 commented 2 years ago

Looks like 1.16.5, I am 99% certain this is fixed in later versions as the save system has gone through several iterations.

Currenly 1.16.5 is not supported but once the player's kingdom is done I will be backporting to these versions.