search

SamB440 / Tale-of-Kingdoms

An adventure of glory in the world of Minecraft - Revival of Tale of Kingdoms mod
GNU General Public License v3.0
16 stars 2 forks source link

Selling items results in double the amount of coins as the sell value. #59

Closed SamB440 closed 1 year ago

SamB440 commented 3 years ago

In GitLab by @jordanplayz158 on Jun 5, 2021, 17:21

Summary

When you go to sell an item, you put the item in the sell slot and then you are given 2x the sell value it is worth (client and server calling the method)

Steps to reproduce

  1. Get a sellable item
  2. Go to any merchant (blacksmith was used in the video)
  3. Go to the sell gui (click on the sell button)
  4. Sell the item

What is the current bug behaviour?

When you sell an item, you get 2x the sell value

What is the expected behaviour?

When you sell an item, you should get 1x the sell value.

Relevant logs and/or screenshots/videos

https://discord.com/channels/282242806695591938/844674162438045736/850769330769362976 OR https://streamable.com/bmcik7

Possible fixes

Will look through code and update issue accordingly.

JordanPlayz158 commented 1 year ago

This was assigned to me but it appears that Sam fixed this issue in both master and tier one so this can now be closed.