search

SamB440 / Tale-of-Kingdoms

An adventure of glory in the world of Minecraft - Revival of Tale of Kingdoms mod
GNU General Public License v3.0
16 stars 2 forks source link

Master - [merged] #80

Closed SamB440 closed 2 years ago

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Nov 10, 2020, 14:21

Merges master -> master

Fully Implemented the Banker. Checks for no coins. Message saying to slay monsters for coins. Deposits and Withdraws with correct Exit message.

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Nov 10, 2020, 14:46

added 7 commits

Compare with previous version

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Nov 10, 2020, 15:16

added 3 commits

Compare with previous version

SamB440 commented 3 years ago

Please don't use brackets etc like this. https://google.github.io/styleguide/javaguide.html

SamB440 commented 3 years ago

Same as +44 to +48

SamB440 commented 3 years ago

Use the local variable instead.

SamB440 commented 3 years ago

Why?

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Nov 10, 2020, 16:03

Commented on src/main/java/net/islandearth/taleofkingdoms/client/gui/entity/BankerScreen.java line 88

changed this line in version 4 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Nov 10, 2020, 16:03

Commented on src/main/java/net/islandearth/taleofkingdoms/client/gui/entity/BlacksmithScreen.java line 11

changed this line in version 4 of the diff

SamB440 commented 3 years ago

In GitLab by @KingCobra_200 on Nov 10, 2020, 16:03

added 1 commit

Compare with previous version

SamB440 commented 3 years ago

resolved all threads

SamB440 commented 3 years ago

approved this merge request

SamB440 commented 3 years ago

enabled an automatic merge when the pipeline for 8a6982d05af9e540dc80ff43c823cdece53d4c19 succeeds

SamB440 commented 3 years ago

mentioned in commit a48cca46e5ffd40709311a8e818f0707f85bcd21